Updating host-process images to use the new base image #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/sig windows |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
sig/windows
github-actions
bot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
size/M
jsturtevant
reviewed
Aug 12, 2022
| @@ -1,5 +1,4 @@ | |||
| ARG OS=1809 | |||
| FROM mcr.microsoft.com/windows/nanoserver:${OS} as runtime | |||
| FROM mcr.microsoft.com/oss/kubernetes/windows-host-process-containers-base-image:v0.1.0 as runtime | |||
There was a problem hiding this comment.
this image is currently using Docker not buildx so I think it won't work. Will need to update the build scripts
There was a problem hiding this comment.
Yea, I noticed taht. Same w/ csi-proxy.
I might just update the images that are building w/ buildkit in the PR and then open a separate PR for these 2 images.
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
marosset
force-pushed
the
use-hostprocess-base-image
branch
from
673d6f1
to
de32f49
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Rossetti marosset@microsoft.com
Reason for PR:
Updating host-process images to use the new base image
Issue Fixed:
Issue #
Requirements
Notes: