Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of base driver image #2142

Closed
wants to merge 8 commits into from
Closed

remove usage of base driver image #2142

wants to merge 8 commits into from

Conversation

nikhilbarge
Copy link
Contributor

What this PR does / why we need it:
If the base driver image is not recently updated, we might end up releasing the driver image with older photon packages.
This Pr will remove usage of base driver image, so every new image we create automatically gets the latest photon packages.

Testing done:
Build new images locally
Run e2e tests

Special notes for your reviewer:

Release note:

remove usage of base driver image, instead get the latest photon packages when built new image.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhilbarge
Once this PR has been reviewed and has the lgtm label, please assign divyenpatel for approval by writing /assign @divyenpatel in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2022
@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1572

@svcbot-qecnsdp
Copy link

Started vanilla file pipeline... Build Number: 646

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link 

File vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1573

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1574

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1575

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1577

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1578

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1579

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1580

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1581

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: make-images

@svcbot-qecnsdp
Copy link

Started vanilla file pipeline... Build Number: 648

@svcbot-qecnsdp
Copy link 

File vanilla build status: FAILURE 
Stage before exit: make-images

@nikhilbarge nikhilbarge changed the title WIP: remove usage of base driver image remove usage of base driver image Jan 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2023
@chethanv28
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

@gohilankit gohilankit Awaiting requested review from gohilankit

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhilbarge @k8s-ci-robot @svcbot-qecnsdp @chethanv28 @k8s-triage-robot