Skip to content

Commit fe1610f

Browse files
dimsk8s-publishing-bot
authored andcommitted
switch from golang-lru to the one in k8s.io/utils
Signed-off-by: Davanum Srinivas <davanum@gmail.com> Kubernetes-commit: 79d0c6cdc10293c9bfe644ce31dc186a936579b0
1 parent 2b00091 commit fe1610f

File tree

4 files changed

+9
-26
lines changed

4 files changed

+9
-26
lines changed

pkg/admission/plugin/resourcequota/resource_access.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,13 @@ import (
2121
"fmt"
2222
"time"
2323

24-
"github.com/hashicorp/golang-lru"
25-
2624
corev1 "k8s.io/api/core/v1"
2725
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2826
"k8s.io/apimachinery/pkg/labels"
2927
"k8s.io/apiserver/pkg/storage/etcd3"
3028
"k8s.io/client-go/kubernetes"
3129
corev1listers "k8s.io/client-go/listers/core/v1"
30+
"k8s.io/utils/lru"
3231
)
3332

3433
// QuotaAccessor abstracts the get/set logic from the rest of the Evaluator. This could be a test stub, a straight passthrough,
@@ -61,14 +60,8 @@ type quotaAccessor struct {
6160

6261
// newQuotaAccessor creates an object that conforms to the QuotaAccessor interface to be used to retrieve quota objects.
6362
func newQuotaAccessor() (*quotaAccessor, error) {
64-
liveLookupCache, err := lru.New(100)
65-
if err != nil {
66-
return nil, err
67-
}
68-
updatedCache, err := lru.New(100)
69-
if err != nil {
70-
return nil, err
71-
}
63+
liveLookupCache := lru.New(100)
64+
updatedCache := lru.New(100)
7265

7366
// client and lister will be set when SetInternalKubeClientSet and SetInternalKubeInformerFactory are invoked
7467
return &quotaAccessor{

pkg/admission/plugin/resourcequota/resource_access_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ import (
2424
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2525
"k8s.io/apimachinery/pkg/runtime"
2626

27-
lru "github.com/hashicorp/golang-lru"
2827
corev1 "k8s.io/api/core/v1"
2928
"k8s.io/client-go/informers"
3029
"k8s.io/client-go/kubernetes/fake"
30+
"k8s.io/utils/lru"
3131
)
3232

3333
func TestLRUCacheLookup(t *testing.T) {
@@ -86,10 +86,7 @@ func TestLRUCacheLookup(t *testing.T) {
8686

8787
for _, tc := range testcases {
8888
t.Run(tc.description, func(t *testing.T) {
89-
liveLookupCache, err := lru.New(1)
90-
if err != nil {
91-
t.Fatal(err)
92-
}
89+
liveLookupCache := lru.New(1)
9390
kubeClient := fake.NewSimpleClientset(tc.clientInput...)
9491
informerFactory := informers.NewSharedInformerFactory(kubeClient, 0)
9592

pkg/storage/value/encrypt/envelope/envelope.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ import (
2626
"time"
2727

2828
"k8s.io/apiserver/pkg/storage/value"
29+
"k8s.io/utils/lru"
2930

30-
lru "github.com/hashicorp/golang-lru"
3131
"golang.org/x/crypto/cryptobyte"
3232
)
3333

@@ -64,14 +64,10 @@ type envelopeTransformer struct {
6464
func NewEnvelopeTransformer(envelopeService Service, cacheSize int, baseTransformerFunc func(cipher.Block) value.Transformer) (value.Transformer, error) {
6565
var (
6666
cache *lru.Cache
67-
err error
6867
)
6968

7069
if cacheSize > 0 {
71-
cache, err = lru.New(cacheSize)
72-
if err != nil {
73-
return nil, err
74-
}
70+
cache = lru.New(cacheSize)
7571
}
7672
return &envelopeTransformer{
7773
envelopeService: envelopeService,

pkg/util/webhook/client.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ import (
2525
"net/url"
2626
"strconv"
2727

28-
"github.com/hashicorp/golang-lru"
2928
"k8s.io/apimachinery/pkg/runtime"
3029
"k8s.io/apimachinery/pkg/runtime/schema"
3130
"k8s.io/apimachinery/pkg/runtime/serializer"
3231
utilerrors "k8s.io/apimachinery/pkg/util/errors"
3332
"k8s.io/apiserver/pkg/util/x509metrics"
3433
"k8s.io/client-go/rest"
34+
"k8s.io/utils/lru"
3535
)
3636

3737
const (
@@ -65,10 +65,7 @@ type ClientManager struct {
6565

6666
// NewClientManager creates a clientManager.
6767
func NewClientManager(gvs []schema.GroupVersion, addToSchemaFuncs ...func(s *runtime.Scheme) error) (ClientManager, error) {
68-
cache, err := lru.New(defaultCacheSize)
69-
if err != nil {
70-
return ClientManager{}, err
71-
}
68+
cache := lru.New(defaultCacheSize)
7269
hookScheme := runtime.NewScheme()
7370
for _, addToSchemaFunc := range addToSchemaFuncs {
7471
if err := addToSchemaFunc(hookScheme); err != nil {

0 commit comments

Comments
 (0)