Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cordon nodes before downscaling #3014

Closed
wants to merge 3 commits into from
Closed

Add cordon nodes before downscaling #3014

wants to merge 3 commits into from

Conversation

fradee
Copy link

@fradee fradee commented Apr 1, 2020

Review, please for solving #2868

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @fradee!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign losipiuk
You can assign the PR to them by writing /assign @losipiuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fradee
fix 'golint' problems:
9df2de9 
/home/travis/gopath/src/k8s.io/autoscaler/cluster-autoscaler/utils/cordon/cordon.go:45:10: if block ends with a return statement, so drop this else and outdent its block
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 1, 2020
@fradee fradee mentioned this pull request Apr 22, 2020
Closed
@hato221
Copy link

hato221 commented May 11, 2020

@losipiuk Hi, any chance to review it? 🙏

mdkent
mdkent reviewed May 26, 2020
View reviewed changes
cluster-autoscaler/main.go
@@ -172,6 +172,7 @@ var (
balancingIgnoreLabelsFlag = multiStringFlag("balancing-ignore-label", "Specifies a label to ignore in addition to the basic and cloud-provider set of labels when comparing if two node groups are similar")
awsUseStaticInstanceList = flag.Bool("aws-use-static-instance-list", false, "Should CA fetch instance types in runtime or use a static list. AWS only")
enableProfiling = flag.Bool("profiling", false, "Is debug/pprof endpoint enabled")
cordonNodeBeforeTerminate = flag.Bool("cordon-node-before-terminate", false, "Should CA cordon nodes before termiante during downscale process")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

termiante -> terminating

@fradee fradee closed this Jun 11, 2020
@fradee fradee deleted the cordon-nodes-before-downscaling branch June 11, 2020 07:38
@hato221
Copy link

hato221 commented Jun 11, 2020

@fradee Hi, did you find another workaround on how to achieve cordoning? 🙏

@nemo83
Copy link

nemo83 commented Jun 18, 2020

I've just found out we are suffering the same issue. Are there alternatives out there?

@carlosjgp
Copy link

Hey @fradee thank you for the PR, this will be brilliant for a CI cluster where new PODs are scheduled to perform short/medium tasks... it's exactly what I need

I'm curious why this PR didn't go through... If you are busy or this is not a problem for you anymore, would you mind if I clone this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdkent mdkent mdkent left review comments

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fradee @k8s-ci-robot @hato221 @nemo83 @carlosjgp @mdkent