Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpa-admission-controller: Contextify status updates. Add timeout of 10s #7036

Merged

Conversation

ialidzhikov
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

For details, see #6884.

Which issue(s) this PR fixes:

Fixes #6884

Special notes for your reviewer:

Does this PR introduce a user-facing change?

vpa-admission-controller: The lease updates that the vpa-admission-controller performs (that are later on checked by the vpa-updater for healthiness of the vpa-admission-controller) are now executed with a timeout of 10s. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2024
@adrianmoisey
Copy link
Member

LGTM!

Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contextifying this. Just one comment on my side which we could potentially also resolve in this PR.

vertical-pod-autoscaler/pkg/utils/status/status_updater.go Outdated Show resolved Hide resolved
@ialidzhikov
Copy link
Contributor Author

[sig-autoscaling] [VPA] [full-vpa] [v1beta2] OOMing pods under VPA [It] have memory requests growing with OOMs
/home/prow/go/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1beta2/full_vpa.go:163
  [FAILED] Unexpected error:
      <*errors.errorString | 0xc00081aa60>: 
      error waiting for memory request in range of ({{1468006400 0} {<nil>}  BinarySI},{{10485760000 0} {<nil>}  BinarySI}) for pods: {TypeMeta:{Kind: APIVersion:} LabelSelector:name=hamster FieldSelector:status.phase!=Failed,status.phase!=Succeeded Watch:false AllowWatchBookmarks:false ResourceVersion: ResourceVersionMatch: TimeoutSeconds:<nil> Limit:0 Continue: SendInitialEvents:<nil>}
      {
          s: "error waiting for memory request in range of ({{1468006400 0} {<nil>}  BinarySI},{{10485760000 0} {<nil>}  BinarySI}) for pods: {TypeMeta:{Kind: APIVersion:} LabelSelector:name=hamster FieldSelector:status.phase!=Failed,status.phase!=Succeeded Watch:false AllowWatchBookmarks:false ResourceVersion: ResourceVersionMatch: TimeoutSeconds:<nil> Limit:0 Continue: SendInitialEvents:<nil>}",
      }
  occurred
  In [It] at: /home/prow/go/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/v1beta2/full_vpa.go:171 @ 07/23/24 08:55:39.616

/test pull-kubernetes-e2e-autoscaling-vpa-full

Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on my side.

@voelzmo
Copy link
Contributor

voelzmo commented Aug 30, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, plkokanov, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit a2b793d into kubernetes:master Sep 16, 2024
7 checks passed
@ialidzhikov ialidzhikov deleted the enh/status-updater-timeout branch September 17, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-work internal health check between vpa-updater and vpa-admission-controller
6 participants