-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use promoted images #267
Merged
Merged
Use promoted images #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Denotes a PR that doesn't merit a release note.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Sep 3, 2021
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Sep 3, 2021
/cc @wongma7 |
rifelpet
reviewed
Sep 4, 2021
* We recently started promoting the tagged ccm images to k8s-artifacts-prod so we should use those instead of the images in k8s-staging-provider-aws.
nckturner
force-pushed
the
use-promoted-images
branch
from
September 8, 2021 00:33
292f02d
to
9b1fd0e
Compare
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 8, 2021
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Sep 8, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note-none
Denotes a PR that doesn't merit a release note.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We recently started promoting the tagged ccm images to k8s-artifacts-prod so we should use those instead of the images in k8s-staging-provider-aws. See k8s-artifacts-prod for the list of promoted images.
Which issue(s) this PR fixes:
Fixes #228
Special notes for your reviewer:
Does this PR introduce a user-facing change?: