Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PDCSI to be the default storage class #353

Closed
wants to merge 1 commit into from
Closed

Set PDCSI to be the default storage class #353

wants to merge 1 commit into from

Conversation

mattcary
Copy link
Contributor

This is necessary for many storage tests to run.

/assign @leiyiz

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattcary
Once this PR has been reviewed and has the lgtm label, please assign vishh for approval by writing /assign @vishh in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@mattcary: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cloud-provider-gcp-e2e-full 75f20e0 link true /test cloud-provider-gcp-e2e-full

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

leiyiz
leiyiz reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the gce-pd is already default sc in this repo.
https://github.com/kubernetes/cloud-provider-gcp/blob/master/cluster/addons/storage-class/gce/default.yaml

@leiyiz
Copy link
Contributor

leiyiz commented Jul 21, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@mattcary mattcary closed this Jul 22, 2022
@mattcary
Copy link
Contributor Author

This is the wrong thing to do, see kubernetes/test-infra#26890 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz leiyiz left review comments

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@leiyiz leiyiz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattcary @k8s-ci-robot @leiyiz