Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove neutron lbaas v1 version code #1882

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Remove neutron lbaas v1 version code #1882

merged 1 commit into from
Dec 14, 2022

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented May 24, 2022 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1833

Special notes for reviewers:

Release note:

neutron lbaas is not supported anymore, we should not keep those data, removed all neutron lbaas v1 code along with the UseOctavia flag, action required.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 24, 2022
@chrigl chrigl added this to the v1.25 milestone May 24, 2022
@chrigl
Copy link
Contributor

chrigl commented May 25, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@chrigl
Copy link
Contributor

chrigl commented May 25, 2022

Just one thing. I think we should update the main README.md, and add the removal to Note

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022
@jichenjc
Copy link
Contributor Author

Just one thing. I think we should update the main README.md, and add the removal to Note

good point, updated~

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2022
@chrigl
Copy link
Contributor

chrigl commented May 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2022
@ramineni
Copy link
Contributor

ramineni commented Jun 1, 2022

/release-note-action-required

@k8s-ci-robot
Copy link
Contributor

@ramineni: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note-action-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

ramineni commented Jun 1, 2022

@ramineni: the /release-note and /release-note-action-required commands have been deprecated. Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.

@jichenjc could you add action required in release note, so that easier to check before upgrade

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 1, 2022
@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 1, 2022

@ramineni added action required. into release notes, thanks

@ramineni
Copy link
Contributor

ramineni commented Jun 1, 2022

@jichenjc Thanks. And also please remove the flag use-octavia from the test manifests and documents.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2022
@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 1, 2022

@ramineni updated, thanks~

@chrigl chrigl mentioned this pull request Jun 3, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022
@jichenjc
Copy link
Contributor Author

@chrigl can you check and merge this ? last for long time and introduce unnecessary code update for some time

@jichenjc jichenjc force-pushed the remove_lbaas branch 2 times, most recently from ecf406f to e8be290 Compare October 27, 2022 02:51
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 27, 2022 •
edited
Loading

@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-csi-manila-e2e-test 1190e8c link true /test openstack-cloud-csi-manila-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@jichenjc
Copy link
Contributor Author

/test openstack-cloud-controller-manager-e2e-test

@jichenjc
Copy link
Contributor Author

/approve

this has been long time and I think no one will approve it
with one lgtm, I am going to approve it

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1117fa2 into kubernetes:master Dec 14, 2022
dulek added a commit to dulek/cluster-cloud-controller-manager-operator that referenced this pull request Jul 12, 2023
@dulek
OpenStack: Remove use-octavia from config
e5803e2 
That option got removed in kubernetes/cloud-provider-openstack#1882. We
don't need to set it anymore and this commit makes sure it's gone from
the configuration.
@dulek dulek mentioned this pull request Jul 12, 2023
Merged
dulek added a commit to dulek/cluster-cloud-controller-manager-operator that referenced this pull request Jul 12, 2023
@dulek
OpenStack: Remove use-octavia from config
a690ad9 
That option got removed in kubernetes/cloud-provider-openstack#1882. We
don't need to set it anymore and this commit makes sure it's gone from
the configuration.
dulek added a commit to dulek/openstack-test that referenced this pull request Jul 13, 2023
@dulek
CCM: Remove check for use-octavia option
70cdcad 
kubernetes/cloud-provider-openstack#1882 removed `use-octavia` option,
so there's no need to set it anymore. This commit makes sure tests
doesn't look for that option.

We could probably check if the option is unset, but that would create a
merge cycle that would be hard to resolve, so let's just stop caring
about that option.
@dulek dulek mentioned this pull request Jul 13, 2023
Merged
dulek added a commit to dulek/cluster-cloud-controller-manager-operator that referenced this pull request Jul 13, 2023
@dulek
OpenStack: Remove use-octavia from config
61ee0d5 
That option got removed in kubernetes/cloud-provider-openstack#1882. We
don't need to set it anymore and this commit makes sure it's gone from
the configuration.
dulek added a commit to dulek/openstack-test that referenced this pull request Jul 13, 2023
@dulek
CCM: Remove check for use-octavia option
fd46435 
kubernetes/cloud-provider-openstack#1882 removed `use-octavia` option,
so there's no need to set it anymore. This commit makes sure tests
doesn't look for that option.

We could probably check if the option is unset, but that would create a
merge cycle that would be hard to resolve, so let's just stop caring
about that option.
@lotharbach lotharbach mentioned this pull request Mar 22, 2024
Open
@chess-knight chess-knight mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaardie shaardie shaardie left review comments

@anguslees anguslees Awaiting requested review from anguslees

@ramineni ramineni Awaiting requested review from ramineni

Assignees

@chrigl chrigl

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

remove lbaas code ? ?
5 participants
@jichenjc @chrigl @ramineni @k8s-ci-robot @shaardie