-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] added dnsPolicy value for nodeplugin #2483
Conversation
Any reason to not just set this directly to |
I might not understand clearly, but seems the changed item is Cinder instead of manila? |
Sorry for the confusion, I mean that in Manila chart we don't make this configurable, just set it directly to |
@dulek Sure, changed as requested. Initially I've set it to |
/lgtm ok, understand, thanks~ @dulek |
I wasn't sure this is the right way, but it makes a lot of sense to be consistent here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds
dnsPolicy
value to cinder-csi-plugin's Helm chart. The default value is set toClusterFirst
, which the current default.Which issue this PR fixes(if applicable):
fixes #2481
Special notes for reviewers:
Release note: