-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] Revert dnsPolicy to Default for occm #2612
[occm] Revert dnsPolicy to Default for occm #2612
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @ericgraf! |
Hi @ericgraf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/hold there are also other files that should be reverted. I will check this currently |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@zetaab any progress on this ? |
it was already merged in #2621 so this can be closed /close |
@zetaab: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Reverts the default value for dnsPolicy.
This is needed during bootstrapping of new clusters where new clusters can't come up due to this change.
Which issue this PR fixes(if applicable):
fixes #2611
Special notes for reviewers:
Release note: