Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Updated .gitignore. #245

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

gyliu513
Copy link
Contributor

/sig multicluster

@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2018
.gitignore Outdated
@@ -1,3 +1,7 @@
/bazel-*
examples/samplecontainer/contents/clusterregistry
examples/samplecontainer/contents/slackcontroller

vendor
Copy link
Contributor

@perotinus perotinus Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe vendor/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@perotinus
Copy link
Contributor

@gyliu513 This looks good overall, but I have one small comment.

@perotinus
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9eb6bda into kubernetes-retired:master Jun 28, 2018
@gyliu513 gyliu513 deleted the ignore branch June 28, 2018 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants