Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping files in /devel folder by SIG #3097

Closed
eduartua opened this issue Jan 14, 2019 · 14 comments

Comments

8 participants
@eduartua
Copy link
Contributor

commented Jan 14, 2019

This is related to #3064

Grouping files by SIGs will allow us to investigate which needs to be updated in a more efficient way. Also, the idea is that SIGs will be the onnwers of that files.

SIG Files
API Machinery generating-clientset.md
strategic-merge-patch.md
controllers.md
Architecture api_changes.md
api-conventions.md
component-config-conventions.md
godep.md
staging.md
conformance-tests.md
CLI kubectl-conventions.md
Contributor Experience automation.md
Instrumentation instrumentation.md
logging.md
event-style-guide.md
Node container-runtime-interface.md
cri-container-stats.md
cri-testing-policy.md
cri-validation.md
node-performance-testing.md
kubelet-cri-networking.md
e2e-node-tests.md
Release cherry-picks.md
getting-builds.md
release.md
Scalability profiling.md
kubemark-guide.md
Scheduling scheduler_algorithm.md
scheduler.md
Storage flexvolume.md
Testing bazel.md
e2e-tests.md
flaky-tests.md
gubernator.md
testing.md
writing-good-e2e-tests.md
@eduartua

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

/sig contributor-experience
/kind feature

@eduartua eduartua referenced this issue Jan 15, 2019

Closed

REQUEST: New membership for @eduartua #366

6 of 6 tasks complete
@nikhita

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

kubectl-conventions.md -> belongs to sig-cli
kubelet-cri-networking.md -> belongs to sig-node or maybe sig-network

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

Thanks.

  • architectural-roadmap.md and arch-roadmap-1.png: I was planning to move these to contributors/design-proposals/architecture, since they aren't particularly actionable for most contributors, and plan to update them soon. Feel free to move them there if I don't get to it soon enough.
  • profiling.md: probably SIG Scalability would be the best fit
  • writing-a-getting-started-guide.md: It's pretty out of date, so we could consider deleting it. Otherwise, I might make it SIG Cluster Lifecycle, SIG Cloud provider, or SIG Docs.
  • adding-an-APIGroup.md: SIG API machinery
  • conformance-tests.md: SIG Architecture
  • event-style-guide.md: SIG Instrumentation
  • on-call-federation-build-cop.md: SIG Multicluster
  • kubemark-guide.md: SIG Scalability
  • staging.md: SIG Architecture
@deads2k

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2019

  1. conformance-tests.md - I don't think apimachinery owns this. I would assign that architecture.
  2. mesos-style.md - is this even still valid? We moved mesos out a long time ago

The rest of apimachinery looks fine.

@eduartua

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

Thank you @deads2k The file conformance-tests.md has been assigned to Architecture. The file mesos-style.md will be removed.

@eduartua

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

@bgrant0607 Do you consider the mesos-style.md file to be deleted?

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

SIG-testing: I'm not authoritative there but LGTM. e2e-node-tests might actually be sig-node, but is probably fine under testing for now. 👍

@brancz

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

SIG Instrumentation looks good in terms of categorization. Instrumentation guide looks good, we'll have to do a pass on logging and events, we haven't looked at those in a while I think.

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

For posterity, the mesos-style.md was removed by this PR:
#3126 (comment)

@eduartua

Please try to use more explanatory PR titles (e.g., rather than "Moving files issue3097") and ensure the PRs reference this issue.

@eduartua

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@eduartua Thanks. I need to browse vast amounts of email, issues, PRs, etc. very quickly, so I mostly need to decide whether to look at them by subject/title and labels.

@eduartua

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

We are done with this issue. Every file has been classified.

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Thanks!
/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

@bgrant0607: Closing this issue.

In response to this:

Thanks!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Experience automation moved this from In Progress to Completed Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.