Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time/day of wg-policy meeting #2546

Closed
wants to merge 1 commit into from
Closed

Conversation

duglin
Copy link

@duglin duglin commented Aug 15, 2018

ws-policy meeting is on wed@4pm PT

Signed-off-by: Doug Davis dug@us.ibm.com

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2018
@k8s-ci-robot k8s-ci-robot added the wg/policy Categorizes an issue or PR as relevant to WG Policy. label Aug 15, 2018
@duglin
Copy link
Author

duglin commented Aug 15, 2018

not sure if the ci failure is real - doesn't seem like its related

@cblecker
Copy link
Member

@duglin CI failure is legitimate, as you're manually modifying an auto-generated doc:

I0815 22:57:33.151] Verifying verify-generated-docs.sh
I0815 22:57:38.545] /go/src/k8s.io/community/wg-policy/README.md does not match /tmp/tmp.t1tT8fjB1d/src/testgendocs/wg-policy/README.md
I0815 22:57:38.546] 
I0815 22:57:38.546] ====================================================================
I0815 22:57:38.546] 1 mismatches were detected.
I0815 22:57:38.546] Do not manually edit sig-list.md or README.md files inside the sig folders.
I0815 22:57:38.546] Instead make your changes to sigs.yaml, then run `make`, and then
I0815 22:57:38.547] commit your changes to sigs.yaml and any generated docs.
I0815 22:57:38.547] ====================================================================
I0815 22:57:38.570] FAILED   verify-generated-docs.sh	5s

Signed-off-by: Doug Davis <dug@us.ibm.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jbeda

If they are not already assigned, you can assign the PR to them by writing /assign @jbeda in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duglin
Copy link
Author

duglin commented Aug 16, 2018

@cblecker doi- thanks! fixing...

@duglin
Copy link
Author

duglin commented Aug 16, 2018

ok fixed! sorry about not noticing it was generated

@hannibalhuang hannibalhuang mentioned this pull request Sep 7, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

@duglin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member

nikhita commented Jan 19, 2019

Closing because this change was made in #2373. Please reopen if needed.

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closed this PR.

In response to this:

Closing because this change was made in #2373. Please reopen if needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/policy Categorizes an issue or PR as relevant to WG Policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants