Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-node: remove unavailable node-perf-dash.k8s.io #7999

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jul 31, 2024

[perf dashboard]: http://node-perf-dash.k8s.io/#/builds

[perf dashboard]: http://node-perf-dash.k8s.io/#/builds

http://node-perf-dash.k8s.io/#/builds this is not available.

Other node related performance dashboard can be found in https://perf-dash.k8s.io/#/?jobname=containerd-node-throughput&metriccategoryname=E2E&metricname=PodStartup&Metric=run_to_watch.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Jul 31, 2024

/cc @SergeyKanzhelev @mrunalp

@k8s-ci-robot k8s-ci-robot added committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/node Categorizes an issue or PR as relevant to SIG Node. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2024
@SergeyKanzhelev
Copy link
Member

Other node related performance dashboard can be found in https://perf-dash.k8s.io/#/?jobname=containerd-node-throughput&metriccategoryname=E2E&metricname=PodStartup&Metric=run_to_watch.

This dashboard is not loading any data

@@ -69,7 +69,6 @@ SIG Technical Leads
[validation]: /contributors/devel/sig-node/cri-validation.md
[testing policy]: /contributors/devel/sig-node/cri-testing-policy.md
[test grid]: https://testgrid.k8s.io/sig-node#Summary
[perf dashboard]: http://node-perf-dash.k8s.io/#/builds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a text using this link above. Can you please delete it as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 95e0531 into kubernetes:master Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants