Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double header #443

Closed
wants to merge 1 commit into from
Closed

Fix double header #443

wants to merge 1 commit into from

Conversation

Harsh3363
Copy link

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Harsh3363 / name: Harsh Kanodiya (4da8162)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Harsh3363!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harsh3363
Once this PR has been reviewed and has the lgtm label, please assign jberkus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 5, 2023
@sftim
Copy link
Contributor

sftim commented Oct 5, 2023

/retitle Fix double header

Relates to #433

@k8s-ci-robot k8s-ci-robot changed the title solved the double header issue #433 Fix double header Oct 5, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

We can't accept this as it does not fix the issue.

You can

You'll see that there are still two similar headings.

If you'd like to ask for help learning about how to fix this, visit https://slack.k8s.io/ for an invitation to Kubernetes Slack, visit the #kubernetes-new-contributors channel and explain your request (for example: you might be asking for someone to volunteer to teach you more about the contribution process, or you might want to learn how static site generators like Hugo typically work).

@Harsh3363
Copy link
Author

Harsh3363 commented Oct 5, 2023

Sorry @sftim will make a PR after resolving the issue.
Thanks for responding

@sftim
Copy link
Contributor

sftim commented Oct 5, 2023

Sorry @sftim mistake from my side has been done in the PR I will make correction in that and will make a PR after that.

I'm not able rightly to apprehend the confusion of ideas here. A fix is still welcome.

@mrbobbytables
Copy link
Member

Going to go ahead and close, there doesn't look like there is any other follow up actions at this point.

/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closed this PR.

In response to this:

Going to go ahead and close, there doesn't look like there is any other follow up actions at this point.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants