Make Resource information card title consistent #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloyekunle, floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
That was quick :) |
Codecov Report
@@ Coverage Diff @@
## master #4103 +/- ##
==========================================
- Coverage 46.4% 46.39% -0.02%
==========================================
Files 194 194
Lines 8922 8922
Branches 83 83
==========================================
- Hits 4140 4139 -1
- Misses 4527 4528 +1
Partials 255 255
Continue to review full report at Codecov.
|
maciaszczykm
pushed a commit
that referenced
this pull request
Aug 26, 2019
* Update node-gyp to the latest version 🚀 (#4010) * chore(package): update node-gyp to version 5.0.2 * chore(package): update lockfile package-lock.json * Update angular2 to the latest version 🚀 (#4007) * fix(package): update @angular/material to version 8.0.2 * fix(package): update @angular/cdk to version 8.0.2 * chore(package): update lockfile package-lock.json * Update @angular/cli to the latest version 🚀 (#4005) * chore(package): update @angular/cli to version 8.1.0 * chore(package): update lockfile package-lock.json * Update del to the latest version 🚀 (#4004) * chore(package): update del to version 5.0.0 * chore(package): update lockfile package-lock.json * Update lint-staged to the latest version 🚀 (#4011) * chore(package): update lint-staged to version 9.0.2 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4016) * chore(package): update @types/node to version 12.0.11 * chore(package): update lockfile package-lock.json * Add xliffmerge to update translated files (#3991) To apply differences of `i18n/messages.xlf` into treanslated files, i.e. `messages.[locale].xlf` like `messages.fr.xlf` and `messages.ja.xlf`, introduce `xliffmerge` and run it after `ng xi18n`. * Add workload statuses to workloads view (#3989) * Reorganize `docs/` (#4009) To migrate wiki contents into `docs/`, prepare directory and file structures. Contents of each pages would be added as latest in subsequent PRs. * CRD Support - Backend (#3843) * Installed k8s.io/apiextensions-apiserver * implement crd list - GetCustomResourceDefinitionList * add method to fetch API extensions client to client manager * implement verber for custom resource definitions * update fakeClient with new client manager methods * add tests for APIExtensionsClient * add events source file * add events test source file * implement objects list endpoint * replace '.Raw' with '.Into' in objects list * implement getCustomResourceObjectDetail * replace kdErrors with errors * fix conflicts * implement get crd detail * implement get events for custom resource object * add version to CustomResourceDefinition type * add (failing) test for detail fetch * add tests for cr objects events * remove unused import * update dependencies * rename customresourcedefinition to crd * removed vendor dir * update deps, remove object tests * order imports * Fix the wording on settings page (#4020) * Fix the wording on settings page * Add messages.new.xlf to .gitignore * Update deploy files (#4019) * Update deploy files * Update image versions * Update build pipeline * Cleanup travis * Restore build before push * Release v2.0.0-beta1 (#4018) * add scraper to recommended. remove amd64 tag (we have manifests now) * Update version to v2.0.0-beta1 * Regenerate package-lock.json * Fix release stage * Fix deploy files * Update c3 to the latest version 🚀 (#4025) * fix(package): update c3 to version 0.7.2 * chore(package): update lockfile package-lock.json * Update lint-staged to the latest version 🚀 (#4026) * chore(package): update lint-staged to version 9.1.0 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4031) * chore(package): update @types/node to version 12.6.0 * chore(package): update lockfile package-lock.json * Update documentations for development guide (#4012) * Getting started * Code conventions * Text conventions * Internationalization * Update lodash to the latest version 🚀 (#4035) * chore(package): update lodash to version 4.17.12 * chore(package): update lockfile package-lock.json * Update @types/lodash to the latest version 🚀 (#4032) * chore(package): update @types/lodash to version 4.14.136 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4036) * chore(package): update @types/node to version 12.6.2 * chore(package): update lockfile package-lock.json * Update xterm to the latest version 🚀 (#4041) * fix(package): update xterm to version 3.14.5 * chore(package): update lockfile package-lock.json * Update @angular-devkit/build-angular to the latest version 🚀 (#4040) * chore(package): update @angular-devkit/build-angular to version 0.801.1 * chore(package): update lockfile package-lock.json * Fix shell and npm dep vulnerability (#4045) * Fix and refactor workload statuses (#4047) * Fix and refactor workload statuses * Fix tests * Update dependencies to support Kubernetes v15.0.0 (#4048) * Update client-go to v12.0.0 Update api and apimachinery to support Kubernetes v15.0.0 * Remove apimachinery override * Remove debug leftover * Remove rf232 from maintainers (#4050) I'm not involved in dashboard anymore, and haven't been for a long time. * Fix skip button on login view (#4051) * Redesign chips (#4049) * Redesign chips * Format the code * Migrate some of the docs (#4052) * Add architecture doc Move images to the new dir * Add deps managment doc * Update some of the docs * Update link to the docs * Add links to the wiki * Update 1.6.x-and-below.md * Update 1.7.x-and-above.md * Update architecture.md * Update karma to the latest version 🚀 (#4057) * chore(package): update karma to version 4.2.0 * chore(package): update lockfile package-lock.json * Plugin controller to manage plugin source from dashboard backend (#4017) * add CRD for Plugin kind * add api types and test plugin yaml file * prepare for codegen * generate code from update-codegen * add pluginclientset.Interface to clientManager and PluginClient method to ClientManager interface * map v1alpha1.PluginList to plugin.PluginList * serve plugin code from configmap data based on spec from Plugin CRD * move plugin specific routes to handler.go in plugin package * move plugin-crd.yml to test-resources * add comments to files * add content type header and remove file extension properly * add tests for plugin package * fix license header errors * Update angular2 to the latest version 🚀 (#4061) * fix(package): update @angular/material to version 8.1.0 * fix(package): update @angular/cdk to version 8.1.0 * chore(package): update lockfile package-lock.json * Migrate docs for `Labels` (#4062) * Fix ingress endpoint resolution (#4033) * init Chinese translation (#4063) * add Simplified Chinese translation * Update package.json * Update angular2 to the latest version 🚀 (#4065) * fix(package): update @angular/material to version 8.1.1 * fix(package): update @angular/cdk to version 8.1.1 * chore(package): update lockfile package-lock.json * Update @types/c3 to the latest version 🚀 (#4066) * fix(package): update @types/c3 to version 0.7.1 * chore(package): update lockfile package-lock.json * Update @types/node to the latest version 🚀 (#4067) * chore(package): update @types/node to version 12.6.6 * chore(package): update lockfile package-lock.json * Update node-gyp to the latest version 🚀 (#4068) * chore(package): update node-gyp to version 5.0.3 * chore(package): update lockfile package-lock.json * Update @angular/cli to the latest version 🚀 (#4076) * chore(package): update @angular/cli to version 8.1.2 * chore(package): update lockfile package-lock.json * Correct typo in markdown formatting (#4074) * Update @types/node to the latest version 🚀 (#4072) * chore(package): update @types/node to version 12.6.7 * chore(package): update lockfile package-lock.json * Restore history service and add auto-refresh (#4080) * Restore history service, add simple auto-refresh, fix view change after delete * Revert lost translations * Update logic * Support dashboard-metrics-scraper on development container (#4046) Deploy `dashboard-metrics-scraper` on `kind` cluster. Then pass `--sidecar-host` to dashboard via `npm` or `gulp`. Also, cleanup handlings of `kubeconfig` for `kind`. * impersonation support for the dashboard (#4082) * Added user impersonation and username to ui * groups working * Added unit tests, extras for impersonation * added docs * fixed formatting to be consistent * updates per pr review * ran npm frontend:fix per travis ci * Reenable namespace change dialog (#4081) * Add namespace change dialog * Apply changes * Make deployment files consistent (#4083) * Bump version to v2.0.0-beta2 (#4084) * add tmp-volume to metrics-scraper (#4087) * add tmp-volume to metrics-scraper * the test resource has slightly different indenting * more indenting differences * Bump gts to 1.0.0 (#4034) Fixed typescript format due to introducing `prettier`. Also, drop `clang-format` in favor of `prettier`. * Update husky to the latest version 🚀 (#4089) * chore(package): update husky to version 3.0.1 * chore(package): update lockfile package-lock.json * Update karma-coverage-istanbul-reporter to the latest version 🚀 (#4099) * chore(package): update karma-coverage-istanbul-reporter to version 2.0.6 * chore(package): update lockfile package-lock.json * make resource information card title consistent (#4103) * [bugfix] Change golang tag (#4106) * [bugfix] Change golang tag `golang:1.12` can't install `openjdk-8-jre`,it's apt source only have 'openjdk-11' so we need change golang's tag for `openjdk-8`. I chenge it to `golang:1.10`, then build mirror successfully in my machine. * Update Dockerfile Restore golang tag, delete openjdk-8-jre dependency * Update semver to the latest version 🚀 (#4107) * chore(package): update semver to version 6.3.0 * chore(package): update lockfile package-lock.json * Update errors.ts (#4109) Fixed grammatical mistake in error msg * Update karma-coverage-istanbul-reporter to the latest version 🚀 (#4111) * chore(package): update karma-coverage-istanbul-reporter to version 2.1.0 * chore(package): update lockfile package-lock.json * Re-install git in development container and suppress download from `golangci-lint` (#4113) husky-3.0 requires git>=2.13.2, but golang:1.12 container image based on devian 9 (stretch) does not satisfy the requirement. So re-install specified version of git from source code. Also, added setting `modules-download-mode: readonly` in `.golangci.yml` to suppress download in running `golangci-lint`. * use KUBECONFIG or default to npmrc (#3593) * Update lint-staged to the latest version 🚀 (#4114) * chore(package): update lint-staged to version 9.2.1 * chore(package): update lockfile package-lock.json * Remove auth cookies when forced logged out (#4119) * Remove auth cookies when forced logged out * Regenerate lockfile * Fix GID on development container (#4120) Run `groupadd` in `gosu-command.sh` when group that has `$LOCAL_GID` does not exist. * Fix chips styling (#4118) * Fix text input (#4122) * Fix exec (#4124) * Fix exec * Remove debug logs * Update @types/jasmine to the latest version 🚀 (#4131) * chore(package): update @types/jasmine to version 3.3.16 * chore(package): update lockfile package-lock.json * Update c3 to the latest version 🚀 (#4133) * fix(package): update c3 to version 0.7.3 * chore(package): update lockfile package-lock.json * Update husky to the latest version 🚀 (#4135) * chore(package): update husky to version 3.0.2 * chore(package): update lockfile package-lock.json * Update @angular/cli to the latest version 🚀 (#4136) * chore(package): update @angular/cli to version 8.1.3 * chore(package): update lockfile package-lock.json * Update angular2 to the latest version 🚀 (#4140) * fix(package): update @angular/material to version 8.1.2 * fix(package): update @angular/cdk to version 8.1.2 * chore(package): update lockfile package-lock.json * Update gts to the latest version 🚀 (#4144) * chore(package): update gts to version 1.1.0 * chore(package): update lockfile package-lock.json * add metrics-provider's no check metrics option (#4143) * Update @angular/cli to the latest version 🚀 (#4148) * chore(package): update @angular/cli to version 8.2.0 * chore(package): update lockfile package-lock.json * CRD Support - Frontend (#4030) * add crd to sidenav * add crd routing * add crd module * fix headers * add divider to sidebar * implement crd list * add crd detail interface * add more columns to table * update crd detail fetch * show crd conditions in crd detail page * added types for crd objects * implement crd objects list * add crd information card and accepted names * add versions table to crd detail * update version table * lint files * add actionbar buttons to crd detail * add status icon * lint fix * update crd object route * wip * update crdobject api * crd object extending resourcelistbase * update objects list * extend verber to support raw crd objects * enable action bar buttons on object detail page * implement raw data display for CRD object * fix failing test * add code section to crdobject * add syntax highlighting * fix issue in i18n file * fix html formatting * Add context menus in list views for cluster resources (#4130) * Migrate e2e tests to Cypress (#4002) * installed cypress and added sample test * readd aot compilation * Prepare for v2.0.0-beta3 (#4152)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Resource information card title consistent across all Resource details page, as Resource information