-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD - e2e Tests #4161
CRD - e2e Tests #4161
Conversation
6e2dfb9
to
c6b6250
Compare
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
==========================================
+ Coverage 46.71% 46.71% +<.01%
==========================================
Files 200 200
Lines 9380 9382 +2
Branches 107 107
==========================================
+ Hits 4382 4383 +1
- Misses 4724 4725 +1
Partials 274 274
Continue to review full report at Codecov.
|
d7832a6
to
077cedb
Compare
We should configure cypress to use typescript and write PO objects to encapsulate some of the page logic into the class. Example page object export class LoginPage {
static getLoginBtn(): Cypress.Chainable<any> {
return cy.get('#login-button');
}
static getLogoutBtn(): Cypress.Chainable<any> {
return cy.get('#navbar-logout-btn');
}
static getLogoutMenuBtn(): Cypress.Chainable<any> {
return cy.get('#navbar-user-menu');
}
static visit(): void {
cy.visit('/');
}
} |
077cedb
to
64c5464
Compare
@eloyekunle: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
src/app/frontend/common/components/list/column/menu/template.html
Outdated
Show resolved
Hide resolved
4e753be
to
18b9ecc
Compare
18b9ecc
to
f301389
Compare
f088280
to
7a08d28
Compare
2 more updates:
|
Great, we can stick with it for now. In the future, it would be really nice to use UI for all of the actions. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloyekunle, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds e2e tests for CRDs using Cypress.
apiextensions
fromv1beta1
tov1
Ref: #4153