Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD - e2e Tests #4161

Merged
merged 12 commits into from
Oct 17, 2019
Merged

Conversation

eloyekunle
Copy link
Contributor

@eloyekunle eloyekunle commented Aug 3, 2019

This PR adds e2e tests for CRDs using Cypress.

  • CRD List
  • CRD Details Page
  • CRD Object Details Page
  • Update apiextensions from v1beta1 to v1

Ref: #4153

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #4161 into master will increase coverage by <.01%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4161      +/-   ##
==========================================
+ Coverage   46.71%   46.71%   +<.01%     
==========================================
  Files         200      200              
  Lines        9380     9382       +2     
  Branches      107      107              
==========================================
+ Hits         4382     4383       +1     
- Misses       4724     4725       +1     
  Partials      274      274
Impacted Files Coverage Δ
src/app/backend/client/verber.go 63.85% <ø> (ø) ⬆️
...ackend/resource/customresourcedefinition/client.go 0% <ø> (ø) ⬆️
...ckend/resource/customresourcedefinition/objects.go 0% <0%> (ø) ⬆️
...rc/app/backend/resource/common/resourcechannels.go 0% <0%> (ø) ⬆️
...ackend/resource/customresourcedefinition/common.go 18.86% <0%> (ø) ⬆️
...ackend/resource/customresourcedefinition/detail.go 0% <0%> (ø) ⬆️
.../backend/resource/customresourcedefinition/list.go 84.84% <100%> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 90.9% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9446035...0dca0e2. Read the comment docs.

@eloyekunle eloyekunle changed the title [WIP]: CRD - e2e Tests CRD - e2e Tests Aug 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2019
@eloyekunle eloyekunle force-pushed the test/integration-crd branch 3 times, most recently from d7832a6 to 077cedb Compare August 7, 2019 12:51
@floreks
Copy link
Member

floreks commented Aug 8, 2019

We should configure cypress to use typescript and write PO objects to encapsulate some of the page logic into the class.

Example page object

export class LoginPage {
  static getLoginBtn(): Cypress.Chainable<any> {
    return cy.get('#login-button');
  }

  static getLogoutBtn(): Cypress.Chainable<any> {
    return cy.get('#navbar-logout-btn');
  }

  static getLogoutMenuBtn(): Cypress.Chainable<any> {
    return cy.get('#navbar-user-menu');
  }

  static visit(): void {
    cy.visit('/');
  }
}

@eloyekunle eloyekunle changed the title CRD - e2e Tests CRD - e2e and Unit Tests Aug 14, 2019
@eloyekunle eloyekunle changed the title CRD - e2e and Unit Tests CRD - e2e Tests Aug 14, 2019
@k8s-ci-robot
Copy link
Contributor

@eloyekunle: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2019
@eloyekunle eloyekunle changed the title WIP: CRD - e2e Tests CRD - e2e Tests Oct 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2019
@eloyekunle
Copy link
Contributor Author

2 more updates:

  1. Bumped kubernetes version used in kind to 1.16.2.
  2. Update apiextensions from v1beta1 to v1.

@maciaszczykm
Copy link
Member

Great, we can stick with it for now. In the future, it would be really nice to use UI for all of the actions.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2cab146 into kubernetes:master Oct 17, 2019
@eloyekunle eloyekunle deleted the test/integration-crd branch October 17, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants