-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styles: Turn off hover effects on disabled buttons #5297
styles: Turn off hover effects on disabled buttons #5297
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @MatonAnthony! |
Codecov Report
@@ Coverage Diff @@
## master #5297 +/- ##
==========================================
- Coverage 45.46% 45.44% -0.02%
==========================================
Files 214 214
Lines 10208 10208
Branches 108 108
==========================================
- Hits 4641 4639 -2
- Misses 5293 5294 +1
- Partials 274 275 +1
Continue to review full report at Codecov.
|
/assign @mhenc |
Turns off the applied .mat-icon-button:hover on .mat-icon-button that are disabled.
6b82c7f
to
6b7538e
Compare
Apparently this changes affect code coverage in backend code and in a component code, this looks flaky to me. |
@MatonAnthony don't worry about codecov check. It does not have to pass. Their calculation algorithm is very weird. We've got it only for information purposes when the source code is actually changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, MatonAnthony The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Turns off the applied .mat-icon-button:hover on .mat-icon-button that are disabled.
This change should fix #5293
This is my first PR to Kubernetes, if anything is missing, I will happily fix it :)