Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles: Turn off hover effects on disabled buttons #5297

Conversation

MatonAnthony
Copy link
Contributor

Turns off the applied .mat-icon-button:hover on .mat-icon-button that are disabled.

This change should fix #5293

This is my first PR to Kubernetes, if anything is missing, I will happily fix it :)

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @MatonAnthony!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #5297 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5297      +/-   ##
==========================================
- Coverage   45.46%   45.44%   -0.02%     
==========================================
  Files         214      214              
  Lines       10208    10208              
  Branches      108      108              
==========================================
- Hits         4641     4639       -2     
- Misses       5293     5294       +1     
- Partials      274      275       +1     
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0.00%> (-1.82%) ⬇️
src/app/frontend/login/component.ts 81.25% <0.00%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec7b50...6b7538e. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 23, 2020
@MatonAnthony
Copy link
Contributor Author

/assign @mhenc

Turns off the applied .mat-icon-button:hover on .mat-icon-button that are disabled.
@MatonAnthony MatonAnthony force-pushed the turn-off-hover-effect-on-disabled-buttons branch from 6b82c7f to 6b7538e Compare June 23, 2020 15:14
@MatonAnthony
Copy link
Contributor Author

Apparently this changes affect code coverage in backend code and in a component code, this looks flaky to me.

@floreks
Copy link
Member

floreks commented Jun 23, 2020

@MatonAnthony don't worry about codecov check. It does not have to pass. Their calculation algorithm is very weird. We've got it only for information purposes when the source code is actually changed.

Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, MatonAnthony

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 988f57b into kubernetes:master Jun 23, 2020
@MatonAnthony MatonAnthony deleted the turn-off-hover-effect-on-disabled-buttons branch July 1, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off hover effect for disabled buttons
4 participants