-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role bindings and cluster role bindings, organize groups and improve the CRD names #5448
Add role bindings and cluster role bindings, organize groups and improve the CRD names #5448
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5448 +/- ##
==========================================
+ Coverage 45.35% 45.40% +0.05%
==========================================
Files 214 214
Lines 10244 10250 +6
Branches 110 110
==========================================
+ Hits 4646 4654 +8
+ Misses 5325 5322 -3
- Partials 273 274 +1
Continue to review full report at Codecov.
|
60e7e42
to
0a5fc3a
Compare
/assign @floreks |
src/app/frontend/resource/cluster/rolebinding/detail/component.ts
Outdated
Show resolved
Hide resolved
src/app/frontend/resource/cluster/clusterrolebinding/detail/component.ts
Show resolved
Hide resolved
PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to #5232.