Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role bindings and cluster role bindings, organize groups and improve the CRD names #5448

Merged
merged 13 commits into from
Aug 27, 2020

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Aug 20, 2020

Related to #5232.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2020
@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Aug 20, 2020
@maciaszczykm maciaszczykm marked this pull request as draft August 20, 2020 10:27
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #5448 into master will increase coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5448      +/-   ##
==========================================
+ Coverage   45.35%   45.40%   +0.05%     
==========================================
  Files         214      214              
  Lines       10244    10250       +6     
  Branches      110      110              
==========================================
+ Hits         4646     4654       +8     
+ Misses       5325     5322       -3     
- Partials      273      274       +1     
Impacted Files Coverage Δ
src/app/backend/api/types.go 35.29% <ø> (ø)
src/app/frontend/overview/component.ts 73.33% <50.00%> (-3.59%) ⬇️
...rontend/common/components/resourcelist/groupids.ts 100.00% <100.00%> (ø)
.../app/frontend/common/services/resource/endpoint.ts 81.66% <100.00%> (+0.63%) ⬆️
src/app/backend/sync/secret.go 73.26% <0.00%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4972092...fab8a4a. Read the comment docs.

@maciaszczykm maciaszczykm changed the title Add role bindings and cluster role bindings views and move the storage classes to the correct section Add role bindings and cluster role bindings views, move the storage classes to the correct section and improve the CRD display names Aug 20, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2020
@maciaszczykm maciaszczykm changed the title Add role bindings and cluster role bindings views, move the storage classes to the correct section and improve the CRD display names Add role bindings and cluster role bindings, move the storage classes and improve the CRD names Aug 20, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review August 20, 2020 12:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@maciaszczykm
Copy link
Member Author

/assign @floreks

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2020
@maciaszczykm maciaszczykm changed the title Add role bindings and cluster role bindings, move the storage classes and improve the CRD names Add role bindings and cluster role bindings, organize groups and improve the CRD names Aug 27, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2020
@maciaszczykm
Copy link
Member Author

PTAL

@floreks
Copy link
Member

floreks commented Aug 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bc2d311 into kubernetes:master Aug 27, 2020
@maciaszczykm maciaszczykm deleted the feature/bindings branch August 27, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants