Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for limit of displayed labels #5477

Merged
merged 7 commits into from
Aug 27, 2020

Conversation

maciaszczykm
Copy link
Member

Fixes #5456.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2020
@k8s-ci-robot k8s-ci-robot added language/de Updates or issues for German translations. language/fr Updates or issues for French translations. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/ja Updates or issues for Japanese translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #5477 into master will decrease coverage by 0.08%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5477      +/-   ##
==========================================
- Coverage   45.35%   45.26%   -0.09%     
==========================================
  Files         214      214              
  Lines       10244    10251       +7     
  Branches      110      111       +1     
==========================================
- Hits         4646     4640       -6     
- Misses       5325     5340      +15     
+ Partials      273      271       -2     
Impacted Files Coverage Δ
.../app/frontend/common/components/chips/component.ts 44.18% <9.09%> (-32.13%) ⬇️
.../frontend/common/services/global/globalsettings.ts 36.00% <50.00%> (+0.58%) ⬆️
src/app/backend/sync/secret.go 73.26% <0.00%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4972092...de98257. Read the comment docs.

@maciaszczykm
Copy link
Member Author

/assign @floreks

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2020
@maciaszczykm
Copy link
Member Author

PTAL

@floreks
Copy link
Member

floreks commented Aug 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm maciaszczykm merged commit f0acd2e into kubernetes:master Aug 27, 2020
@maciaszczykm maciaszczykm deleted the feature/labels-limit branch August 27, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show more labels / restrict by display size of labels
3 participants