Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh translation #5684

Merged
merged 4 commits into from
Nov 19, 2020
Merged

update zh translation #5684

merged 4 commits into from
Nov 19, 2020

Conversation

helight
Copy link
Contributor

@helight helight commented Nov 13, 2020

  1. fix some words
    2.translation some word we haven't
    3.we did't translate some words because we think we should't do it and those words show keep. but I find that those has already translated in the kubernetes doc, here is some url for kubernetes zh doc:

You can find more here : https://kubernetes.io/zh/docs

before this pr, the old UI is like this:
image

now with this pr it is like this:
image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/zh Updates or issues for Chinese translations. labels Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5684 (7f2c5d4) into master (26eaf08) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5684      +/-   ##
==========================================
+ Coverage   44.36%   44.39%   +0.02%     
==========================================
  Files         214      214              
  Lines        9119     9119              
  Branches      113      113              
==========================================
+ Hits         4046     4048       +2     
+ Misses       4798     4797       -1     
+ Partials      275      274       -1     
Impacted Files Coverage Δ
src/app/frontend/login/component.ts 76.74% <0.00%> (+1.16%) ⬆️
...p/backend/integration/metric/common/aggregation.go 90.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26eaf08...e11e60a. Read the comment docs.

@zehuaiWANG
Copy link
Contributor

image

I would rather keep it in English than translate it into Chinese. It's more like our manipulation of kubectl.
What is your opinion? @hwdef

@helight
Copy link
Contributor Author

helight commented Nov 13, 2020

image

I would rather keep it in English than translate it into Chinese. It's more like our manipulation of kubectl.
What is your opinion? @hwdef

This kind version has some problem: some items are english, some are Chinese. it‘s realy confused

Other reason is that the members in k8smeetup community translated all kubernetes documents to Chinese, and those words are all translated to Chinese. you guys can find here https://kubernetes.io/zh/docs. So I think we should translate it as well

@hwdef
Copy link
Member

hwdef commented Nov 13, 2020

These translations look good, but there is still confusion about things like configmap and secrets. not sure if there is a good solution for this.

@tanjunchen @tengqm @chenrui333
Do you have any suggestions?

@tengqm
Copy link

tengqm commented Nov 14, 2020

On website, we don't translate the resource names such as ConfigMap, Secret, Deployment etc. When we are talking about generic terms such as namespace, roles, volumes, we do translate where appropriate.

In this context, I'd vote for not translating the resource names. Strictly speaking, the English source needs some changes as well, because in Kubernetes, nothing is called "Daemon Sets", we only have "DaemonSets". We may want to treat "RoleBindings" as a single term rather than two words "Role Bindings".

Take "Roles" and "ClusterRoles" as examples. If we split the second term into "Cluster Roles", users may see it as a special case of "Roles", so it should be put under the "Roles" group. However, the fact is that "Role" and "ClusterRole" are two separate concepts. If we really want to use "Cluster Roles", we should say "Generic Roles" rather "Roles".

Just my two cents.

@helight
Copy link
Contributor Author

helight commented Nov 14, 2020

@tanjunchen @tengqm @chenrui333 @zehuaiWANG
I found that in Japanese, Korean they translated nearly all words, include Deployments, Cron Jobs, Daemon Sets.
In French and German they just translated some of those words。

@hwdef
Copy link
Member

hwdef commented Nov 14, 2020

@helight
I think Japanese and Korean cannot be used as a reference. We have different language systems.

For example, pods is ポッド in Japanese , 파드 in Korean. . The reason for this translation is the same pronunciation.

@tengqm
Thanks for your suggestion.

@helight
Copy link
Contributor Author

helight commented Nov 19, 2020

@tanjunchen @tengqm @chenrui333 @zehuaiWANG
hi all guys take a look please, I roll back some translation of resource names.

@hwdef
Copy link
Member

hwdef commented Nov 19, 2020

/lgtm

Thanks for your contributions!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helight, hwdef

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 265e1d8 into kubernetes:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants