-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes table now show the number of pods #5723
Nodes table now show the number of pods #5723
Conversation
Welcome @marcosdiez! |
Codecov Report
@@ Coverage Diff @@
## master #5723 +/- ##
==========================================
+ Coverage 44.36% 44.37% +0.01%
==========================================
Files 214 214
Lines 9124 9124
Branches 113 113
==========================================
+ Hits 4048 4049 +1
Misses 4801 4801
+ Partials 275 274 -1
Continue to review full report at Codecov.
|
@marcosdiez you should also add the langue for i18 |
@helight Done! I kept my changes in different commits to keep the code review easy. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, marcosdiez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I modified the
nodes
table to also show the amount of pods.This is quite useful on AWS, where depending on the network setting and machine size on uses, the number of pods is quite limited.
This is how it looks like now: