Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor log viewer, remove follow logs option and fix autorefresh #5868

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 4, 2021

Fixes #5854

  • Complete refactoring of log viewer styling. Flex instead of absolute positioning.
  • Auto-adjust height/width of log viewer to the window size up to the min. values. It was a bit buggy previously.
  • Used theming framework to properly define colors inside the log viewer
  • Removed the Follow logs option as it was not clear what it was actually doing. Instead, when autorefresh is applied and the user scrolls to the bottom of the log viewer it will automatically scroll to the latest part on refresh.
  • Slightly changed timestamp formatting
  • Fixed auto-refresh option and refactored component a bit

New timestamp

Zrzut ekranu z 2021-03-11 11-34-35

Old timestamp

Zrzut ekranu z 2021-03-11 11-34-50

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added language/de Updates or issues for German translations. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #5868 (653433c) into master (d944f37) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5868   +/-   ##
=======================================
  Coverage   44.40%   44.40%           
=======================================
  Files         215      215           
  Lines        9175     9175           
  Branches      113      113           
=======================================
  Hits         4074     4074           
  Misses       4827     4827           
  Partials      274      274           

@floreks floreks changed the title [WIP] Refactor log viewer, remove follow logs option and fix autorefresh Refactor log viewer, remove follow logs option and fix autorefresh Mar 11, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2021
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2021
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow logs does not work
3 participants