Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chinese translations #5964

Merged
merged 2 commits into from
Apr 9, 2021
Merged

update chinese translations #5964

merged 2 commits into from
Apr 9, 2021

Conversation

helight
Copy link
Contributor

@helight helight commented Apr 6, 2021

1.update some Chinese translations
2.do some cleanup

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #5964 (3f85f21) into master (d78c6b0) will decrease coverage by 2.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5964      +/-   ##
==========================================
- Coverage   44.40%   41.99%   -2.41%     
==========================================
  Files         215      216       +1     
  Lines        9175     9325     +150     
  Branches      113      155      +42     
==========================================
- Hits         4074     3916     -158     
- Misses       4826     5157     +331     
+ Partials      275      252      -23     

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor improvement suggestions, others lgtm

@helight
Copy link
Contributor Author

helight commented Apr 7, 2021

/retest

@helight helight requested a review from chenrui333 April 7, 2021 02:59
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2021
@helight
Copy link
Contributor Author

helight commented Apr 9, 2021

@tanjunchen please take a look at this pr.

@helight
Copy link
Contributor Author

helight commented Apr 9, 2021

/assign @hwdef

Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helight thanks for your job!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333, helight, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 30e3080 into kubernetes:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants