Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to workload status charts #5994

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

maciaszczykm
Copy link
Member

Zrzut ekranu 2021-04-15 o 16 22 28

Closes #5078.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #5994 (f5aa219) into master (a1aaa9b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5994      +/-   ##
==========================================
+ Coverage   41.96%   42.00%   +0.03%     
==========================================
  Files         216      216              
  Lines        9329     9333       +4     
  Branches      155      155              
==========================================
+ Hits         3915     3920       +5     
+ Misses       5163     5162       -1     
  Partials      251      251              

@shu-mutou
Copy link
Contributor

Could you update translation files?

@maciaszczykm
Copy link
Member Author

@shu-mutou PTAL

@k8s-ci-robot k8s-ci-robot added language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/zh Updates or issues for Chinese translations. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2021
@shu-mutou
Copy link
Contributor

shu-mutou commented Apr 16, 2021

@maciaszczykm Thank you! But Static Check on CI detects changes for translation files. https://github.com/kubernetes/dashboard/runs/2360849927?check_suite_focus=true#step:8:144
As far as I remember, this number was 9 in previous check.

Could you check differences between CI and your environment?

@maciaszczykm
Copy link
Member Author

I'm using node v14.11.0. I'll get commits from master and run npm ci once more. Perhaps being on Mac also has some impact.

@maciaszczykm
Copy link
Member Author

@shu-mutou No changes. It seems that it will not change. My guess would be the operating system difference.

@maciaszczykm
Copy link
Member Author

I have plans to setup my workspace once more in the close future, so then I'll verify it closely.

@maciaszczykm
Copy link
Member Author

@shu-mutou No changes 😞 At this point I don't have any other idea...

@floreks
Copy link
Member

floreks commented Apr 29, 2021

Has to be an angular issue with the i18n service.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 795a422 into kubernetes:master Apr 29, 2021
@maciaszczykm maciaszczykm deleted the feature/status-labels branch April 29, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the number of active items in workload status
4 participants