Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node bump & resource list refresh #6014

Merged
merged 16 commits into from
May 20, 2021
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Apr 22, 2021

There will be quite a lot of changes here:

  • increase watcher limit in our CI config
  • major bump of required Node version from v10 to v14
  • start using es modules and slowly fade out unsupported dependencies
  • update columns on workload resource lists (related to Pods list show images #6007)
    • added images column to all supported resources
    • added more styling classes for columns kd-col-[xs|sm|md|gt|auto]
    • shrinked some smaller columns (pod count, age, etc.) that took too much space
    • repositioned columns on lists to match each other better
  • bumped all dependencies that could be updated
  • got rid of this annoying watcher error in our e2e tests by bumping inotify watchers system limit
  • got rid of direct JSON file imports as the new Node version does not allow that
  • cleanup, update and fix our i18n pipeline (it should not longer regenerate all i18n files after every small change)
  • and more...

Fixes #4002 and fixes #6065

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #6014 (f2cfe74) into master (688f30a) will decrease coverage by 1.86%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master    #6014      +/-   ##
==========================================
- Coverage   41.55%   39.68%   -1.87%     
==========================================
  Files         216      222       +6     
  Lines        9350     9358       +8     
  Branches      157      143      -14     
==========================================
- Hits         3885     3714     -171     
- Misses       5213     5396     +183     
+ Partials      252      248       -4     

@maciaszczykm
Copy link
Member

@floreks Please rebase, I've already merged #6005 which was created a bit before.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Apr 29, 2021
@maciaszczykm
Copy link
Member

@floreks This will probably close #4024 too.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 13, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels May 13, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
@floreks floreks changed the title [WIP] Node bump & resource list refresh Node bump & resource list refresh May 20, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2021
@maciaszczykm
Copy link
Member

/lgtm
/hold

Unless you want to change something then it's good to merge.

On macOS there might be some issues with missing nan pacakge that require installing it globally and adding to Node path.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floreks floreks mentioned this pull request May 20, 2021
@floreks
Copy link
Member Author

floreks commented May 20, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7a5d7e2 into kubernetes:master May 20, 2021
@floreks floreks deleted the deps/bump branch May 20, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade angular v12 and expose new @use-based Sass API
3 participants