Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore serialized reference component #6090

Merged

Conversation

maciaszczykm
Copy link
Member

Zrzut ekranu 2021-05-20 o 12 15 37

Fixes #3948.

Previous state: screenshot, template, component
Sample data: 1, 2, 3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@maciaszczykm
Copy link
Member Author

/assign @floreks

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #6090 (e7083a1) into master (63c9c84) will decrease coverage by 0.42%.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##           master    #6090      +/-   ##
==========================================
- Coverage   41.97%   41.55%   -0.43%     
==========================================
  Files         216      216              
  Lines        9329     9350      +21     
  Branches      155      157       +2     
==========================================
- Hits         3916     3885      -31     
- Misses       5161     5213      +52     
  Partials      252      252              

@floreks
Copy link
Member

floreks commented May 20, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 688f30a into kubernetes:master May 20, 2021
@maciaszczykm maciaszczykm deleted the feature/serialized-reference branch August 12, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore serialized reference component
3 participants