Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added seccompProfile to dashboard spec #6615

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

Garima-Negi
Copy link
Contributor

@Garima-Negi Garima-Negi commented Nov 7, 2021

  • This PR adds the securityContext block to kubernetes-dashboard spec in recommended.yaml
  • Fixes issue Deploy and Access the Kubernetes Dashboard website#29917
  • currently we get an error : error: error validating "https://raw.githubusercontent.com/kubernetes/dashboard/v2.4.0/aio/deploy/recommended.yaml": error validating data: ValidationError(Deployment.spec.template.spec.securityContext): unknown field "seccompProfile" in io.k8s.api.core.v1.PodSecurityContext; if you choose to ignore these errors, turn validation off with --validate=false

when running commands from website: kubectl apply -f https://raw.githubusercontent.com/kubernetes/dashboard/v2.4.0/aio/deploy/recommended.yaml

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @Garima-Negi!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2021
@Garima-Negi
Copy link
Contributor Author

/assign @jeefy

@floreks
Copy link
Member

floreks commented Nov 16, 2021

All deployment files have to be updated, not only this single recommended.yaml.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 23, 2021

CLA Signed

The committers are authorized under a signed CLA.

@Garima-Negi
Copy link
Contributor Author

Added securityContext in the Deployment for head.yaml and alternative.yaml

@Garima-Negi
Copy link
Contributor Author

All deployment files have to be updated, not only this single recommended.yaml.

done. Let me know if further changes are required

@floreks
Copy link
Member

floreks commented Nov 23, 2021

There are also 3 directories there with the same names and a helm chart that also should be updated.

@Garima-Negi
Copy link
Contributor Author

Garima-Negi commented Nov 23, 2021

There are also 3 directories there with the same names and a helm chart that also should be updated.

Thank you for your comments.
So under the head, recommended and alternative directories, the dashboard-deployment.yaml and scraper-deployment.yaml files already have spec: securityContext: seccompProfile: type: RuntimeDefault

  • similarly for helm chart : the securityContext will be generated - link to code
    with value set in values.yaml

  • Am I looking at the correct directories you mentioned above? Correct me if wrong.

@floreks
Copy link
Member

floreks commented Nov 23, 2021

Great. Thanks for making sure it's there.

/lgtm

@floreks floreks added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #6615 (af360b2) into master (15300bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6615   +/-   ##
=======================================
  Coverage   42.59%   42.59%           
=======================================
  Files         217      217           
  Lines       10650    10650           
  Branches      177      177           
=======================================
  Hits         4536     4536           
  Misses       5813     5813           
  Partials      301      301           

@floreks
Copy link
Member

floreks commented Nov 29, 2021

/lgtm

@floreks floreks merged commit 274c5e5 into kubernetes:master Nov 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, Garima-Negi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitsingh241
Copy link

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants