Fix node event (/node/{name}/event) can not get the whole node event

[SihengCui]

Using the kubectl command, I can get the node event like this:

However, on the dashboard, I cannot view any node events.

The reason of such problem is that, the k8s dashboard transmits node.UID to client-go for selection the involvedObject.uid of node event.

Kubectl kubectl(describe node), it use ref.UID=node.name for searching.

In kubernetes/kubernetes/issues/100236 , he reported a bug. That, the involvedObject.uid of node event may be node_uid or node_name.

So I set the uid of the search reference to "". It will not use involvedObject.uid to searching the node event, so that we can get the whole node event to handel both cases.

[linux-foundation-easycla]

• ❌ The commit (b3e8f07) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @SihengCui!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[linux-foundation-easycla]

• ❌ The commit (b3e8f07) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[SihengCui]

CLA signed

[SihengCui]

It is a natural way to use ref.uid=node.uid to select.
But for some node events, node.uid may not be generated. So some components write node.name to the involvedObject.uid of the node event.
I have now removed the uid filter condition, Is there a better solution?
This is my first pr to cncf community, it's my pleasure to get your advise. @floreks @shu-mutou

[floreks]

I am wondering if keeping an empty UID won't result in getting event information from the unrelated (similar) nodes. It might be better to first try with the UID and if it will return an empty result then retry with UID set to node.name.

[SihengCui]

In my test environment, there are 9 node events at that time. 8 of them involvedObject.uid (from kubelte) are node_name , and 1 of them is node_uid.

Is it necessary to search with uid first (1 result) and then search with nodename (8 results)? finally list append the results.

If uid="", just use involvedObject.name=node.name to search. Theoretically, the node name of k8s is uniquely. But I dont know if there are risks elsewhere.

[SihengCui]

I am wondering if keeping an empty UID won't result in getting event information from the unrelated (similar) nodes. It might be better to first try with the UID and if it will return an empty result then retry with UID set to node.name.

If so, you have to find twice.
If the empty uid can meet the requirements, only use involvedObject.name=node.name to find, it might be easier.

XD kubernetes/pull/106485He also provided a similar method to solve this problem

[SihengCui]

I am wondering if keeping an empty UID won't result in getting event information from the unrelated (similar) nodes. It might be better to first try with the UID and if it will return an empty result then retry with UID set to node.name.

@floreks Some new work was submitted. node,Name and node.UID are both set as node.UID for searching. At the end, The results were integrated.

[floreks]

Can you elaborate? Will it be fixed on the K8S core side or what?

[SihengCui]

Can you elaborate? Will it be fixed on the K8S core side or what?

@floreks
As in kubernetes/issues/100236 , node events are two situations.
I think it is caused by different core components of kubernetes. When some node events are generated, the uid of the node is not generated. Therefore the involvedObject.uid is set to node.name.

The original logic of the k8s dashboard is to query the node info first, and directly apply it to the query conditions of the node event. In this way, a part of the node event is lost, which involvedObject.uid = node.name .

In this PR, the two cases were queried separately in dashborad. Then integrate them. So the return of node event is complete.

[codecov]

Codecov Report

Merging #6649 (a38de4d) into master (6c249bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6649   +/-   ##
=======================================
  Coverage   41.89%   41.89%           
=======================================
  Files          44       44           
  Lines        1234     1234           
  Branches      163      163           
=======================================
  Hits          517      517           
  Misses        717      717           

[floreks]

Please fix the CI (npm run fix should be enough).

[SihengCui]

Please fix the CI (npm run fix should be enough).

@floreks Sorry. I clicked the reset review by mistake. Also, please describe Fix CI in detail. This is my first submission and I am not very familiar with the process.

[SihengCui]

I have changed the go imports order to fix the CI.

[floreks]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, SihengCui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment