Fix advanced settings button name on create form

[prnam]

This change will fix switch advanced settings button name present on Create from form

This what we see currently -
Action to hide is executing perfectly, however button name is always "Show advanced settings".

dashboard/src/app/frontend/create/from/form/template.html

Line 371 in ffd9798

{isMoreOptionsEnabled(), select, 1 {Hide advanced options} other {Show advanced options}}

After PR is accepted this how it will look -

dashboard/src/app/frontend/create/from/form/template.html

Line 371 in f8918f3

{isMoreOptionsEnabled(), select, true {Hide advanced options} other {Show advanced options}}

[floreks]

"Hide Advanced Options" is intentional. It indicates what will happen after clicking this button. We do not want to have 2x the same message. It should be dynamic.

[prnam]

"Hide Advanced Options" is intentional. It indicates what will happen after clicking this button. We do not want to have 2x the same message. It should be dynamic.

I did not understand you, @floreks. Did you mean you support this PR which will change current 2x same message ( i.e Show advanced settings) to getting Hide advanced settings text working on the button? 🤔

[prnam]

Hey @chenrui333, @helight,
Kindly review this PR and let me know if there is anything you need from my end. 🙂

[floreks]

"Hide Advanced Options" is intentional. It indicates what will happen after clicking this button. We do not want to have 2x the same message. It should be dynamic.

I did not understand you, @floreks. Did you mean you support this PR which will change current 2x same message ( i.e Show advanced settings) to getting Hide advanced settings text working on the button? 🤔

Sorry for the late response. Initial issue description was a bit misleading for me also and I thought we already have Show/Hide text.

This change LGTM :)

[floreks]

/lgtm

[floreks]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, prnam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, prnam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment