Fix bug in multiple removal from crd versions list

[shixuyue]

If there are multiple served = false in the crd versions list, the original logic will break since the it will result in out of bond error.

Using the basic for loop to check if the Served field is false, if so, remove it from the version list, and shrink the size of list by 1 to avoid out of bond error.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ shixuyue (f78ffd4)

[k8s-ci-robot]

Welcome @shixuyue!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[floreks]

Fixes #6632

[codecov]

Codecov Report

Merging #6840 (035d965) into master (2d477f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6840   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files          44       44           
  Lines        1228     1228           
  Branches      162      162           
=======================================
  Hits          511      511           
  Misses        717      717           

[floreks]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shixuyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment