Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve French I18N #7656

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Improve French I18N #7656

merged 4 commits into from
Mar 27, 2023

Conversation

jeffmaury
Copy link
Contributor

@jeffmaury jeffmaury commented Mar 13, 2023

Ready for review

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jeffmaury!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feloy March 13, 2023 08:06
@k8s-ci-robot k8s-ci-robot added the language/fr Updates or issues for French translations. label Mar 13, 2023
@feloy
Copy link
Member

feloy commented Mar 13, 2023

Draft as I want to make sure I'm on right path

Yes, that seems good to me up to now.
Thanks for your help on this translation

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2023
@jeffmaury jeffmaury marked this pull request as ready for review March 14, 2023 08:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@maciaszczykm
Copy link
Member

@feloy can you review it?

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #7656 (a52b1af) into master (ac08146) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a52b1af differs from pull request most recent head 109233c. Consider uploading reports for the commit 109233c to get more accurate results

@@            Coverage Diff             @@
##           master    #7656      +/-   ##
==========================================
- Coverage   42.16%   42.16%   -0.01%     
==========================================
  Files         217      217              
  Lines       12092    12092              
  Branches      179      179              
==========================================
- Hits         5099     5098       -1     
- Misses       6708     6709       +1     
  Partials      285      285              

@feloy
Copy link
Member

feloy commented Mar 17, 2023

@feloy can you review it?

Yes, I will do

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Copy link
Member

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes, and propositions
Thanks for your help on this translation

modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
modules/web/i18n/fr/messages.fr.xlf Outdated Show resolved Hide resolved
jeffmaury and others added 2 commits March 27, 2023 08:21
Co-authored-by: Philippe Martin <contact@elol.fr>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested a review from feloy March 27, 2023 06:28
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@feloy
Copy link
Member

feloy commented Mar 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, jeffmaury

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f95024b into kubernetes:master Mar 27, 2023
@jeffmaury jeffmaury deleted the fr branch March 28, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Updates or issues for French translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants