Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Update the spec for federation #29

Closed
johnbelamaric opened this issue Jan 13, 2017 · 10 comments
Closed

Spec: Update the spec for federation #29

johnbelamaric opened this issue Jan 13, 2017 · 10 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@johnbelamaric
Copy link
Member

The current spec covers only a single cluster. It needs to be updated to reflect federation records and behavior.

@thockin
Copy link
Member

thockin commented Jan 13, 2017

The federation records need to be totally revamped - last I looked at them they were ambiguous. @csbell @madhusudancs

@csbell
Copy link

csbell commented Jan 17, 2017

@thockin The best reference outside of code that I could find is located here. By revamp, do you mean merging the current federation behavior into the spec here or is there more involved?

@thockin
Copy link
Member

thockin commented Jan 18, 2017 via email

@bowei
Copy link
Member

bowei commented Jan 18, 2017

Given federation is still in its early stages, it would be great to get ahead of this issue

@madhusudancs
Copy link
Contributor

madhusudancs commented Jan 23, 2017

Oh wow! Did not know about the existence of this repo and was hence missing the notifications.

We proposed something like mysvc.myns.myfed.fed.u7s.io as an alternative,
but we need a plan to migrate people. Madhu might recall more details.

This and in addition we had the literal svc somewhere in there, IIRC. Something like mysvc.myns.svc.myfed.fed. We still need to come up with a concrete migration plan.

There is also this doc that Quinton wrote - https://docs.google.com/document/d/1tSTgqSy7iR8cQx2z-bbqaYVITrraDQmV_aE43PuRPoI/edit#heading=h.ys8jzm2jzab9

@nikhiljindal
Copy link
Contributor

Also ref kubernetes/kubernetes#27969

We proposed something like mysvc.myns.myfed.fed.u7s.io as an alternative,

We had also discussed supporting DNS names for ingress. So fsvc and fing should be better than fed.
Also, with that proposal, we will need more than 6 dots for stateful sets (extra dot for federation name). Is that acceptable?

Given federation is still in its early stages, it would be great to get ahead of this issue

+1.

@bowei
Copy link
Member

bowei commented Jan 23, 2017

@nikhiljindal One thing to keep in mind, increases in ndots can have a dramatic impact on performance.

When a name has fewer dots than ndots, external names result in 10 DNS lookups/name. Modulo negative caching, this can easily result in DNS server meltdown.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants