Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide recommended .status.conditions schema #1623

Closed
deads2k opened this issue Mar 23, 2020 · 22 comments
Closed

provide recommended .status.conditions schema #1623

deads2k opened this issue Mar 23, 2020 · 22 comments
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@deads2k
Copy link
Contributor

deads2k commented Mar 23, 2020

provide recommended .status.conditions schema

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Mar 23, 2020
@lavalamp
Copy link
Member

lavalamp commented Mar 23, 2020

+1

@etune @liggitt fyi

I'd like to suggest the current pattern should add:

  • Observed generation field (what version of the spec is this condition about, if applicable?
  • Identity field (what controller / actor observed this condition)? (possibly, we could use the fieldManager instead of adding a field.)

Both would make multiple controller interactions simpler / more transparent. (Think: kubelet / NPD / node controller)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 1, 2020

Hi @deads2k !

1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

The KEP PR must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

Please let me know and I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 16, 2020

/tracked yes

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels May 16, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 16, 2020

/milestone 1.19

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 16, 2020

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 16, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 16, 2020
@kikisdeliveryservice kikisdeliveryservice modified the milestone: v1.19 May 16, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 16, 2020

Hi @deads2k

As a quick note: #1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled. You can find the template at https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 16, 2020

I also notice that the merged KEP does not have the required test plans: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1623-standardize-conditions

Will they be added by the enhancements deadline on Tuesday May 19th?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 18, 2020

Hi @deads2k

As a reminder, enhancements freeze is tomorrow EOD PST. In order to be included in 1.19 all KEPS must be implementable with graduation criteria and a test plan.

Thanks.

@deads2k
Copy link
Contributor Author

deads2k commented May 19, 2020

Since we're talking about a struct, not new functionality, there isn't something to test beyond standard unit and verify scripts. I'll open a PR to the KEP.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 19, 2020

Thanks @deads2k please link the PR to this issue once it is up.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 19, 2020

Ahh already done!! great!!

#1799

I have updated the tracking sheet and marked the Enhancement as tracked. Thank you!

@zestrells
Copy link

zestrells commented May 25, 2020

Hi @deads2k - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 28, 2020

Hi @deads2k

As a reminder that the Code Freeze is June 25th. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.19 Enhancements Team

@zestrells
Copy link

zestrells commented Jun 8, 2020

Hi @deads2k - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 15, 2020

Hi @deads2k ,

To follow-up on the email sent to k-dev today, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19

We expect all PRs to be merged by that time. Please let me know if you have any questions. 😄

Best,
Kirsten

@RainbowMango
Copy link
Member

RainbowMango commented Jun 20, 2020

@zestrells

Does this enhancement require any changes to docs?

As mentioned by @deads2k at #1623 (comment), this KEP not bring new functionality, so, I guess no need to update docs in k8s.io.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 7, 2020

Hi @deads2k :

As a reminder this Thursday, July 9th is code freeze. All PRs must be merged by EOD PST.

As of right now I see two outstanding PRs:
kubernetes/kubernetes#92519
kubernetes/kubernetes#92660

Is this correct?

If your PRs do not merge, you will need to file an enhancement exception to make it into 1.19. Please let me know if you have any questions.

Thanks!
Kirsten

@deads2k
Copy link
Contributor Author

deads2k commented Sep 10, 2020

This was implemented in 1.19.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Hi deads2k,

Can you please update the KEP to reflect a status of implemented?
See: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml

Thanks
Kirsten

@kikisdeliveryservice kikisdeliveryservice removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 12, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Sep 22, 2020

Hi deads2k,

Can you please update the KEP to reflect a status of implemented?
See: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml

Thanks
Kirsten

got it in #2003 I think. Thanks.

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.19 milestone Oct 1, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 1, 2020

PR finally merged!

Re-closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

6 participants