Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning mechanism for use of deprecated APIs #1693

Closed
liggitt opened this issue Apr 16, 2020 · 33 comments · Fixed by #2875
Closed

Warning mechanism for use of deprecated APIs #1693

liggitt opened this issue Apr 16, 2020 · 33 comments · Fixed by #2875
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@liggitt
Copy link
Member

liggitt commented Apr 16, 2020

Warning mechanism for use of deprecated APIs

  • One-line enhancement description (can be used as a release note): Use of deprecated APIs produces warnings visible to API consumers, and metrics visible to cluster administrators.
  • Kubernetes Enhancement Proposal: KEP 1693: Warning mechanism for use of deprecated APIs #1694
  • Primary contact (assignee): @liggitt
  • Responsible SIGs: api-machinery, architecture, cli
  • Enhancement target (which target equals to which milestone):
    • Beta: 1.19
    • GA: 1.22
@liggitt liggitt self-assigned this Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 16, 2020
@liggitt liggitt changed the title Make use of deprecated APIs and features more visible Make use of deprecated and prerelease APIs more visible Apr 16, 2020
@liggitt liggitt changed the title Make use of deprecated and prerelease APIs more visible Warning mechanism for use of deprecated APIs Apr 16, 2020
@johnbelamaric johnbelamaric added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 4, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 13, 2020

Hi @liggitt, as I believe you are aware we recently merged #1620 which adds the PRR questions to the KEP, as well as some additional metadata to the kep.yaml. Please update the KEP when you have a chance. Thanks!

@zestrells
Copy link

zestrells commented May 25, 2020

Hi @liggitt - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@liggitt
Copy link
Member Author

liggitt commented May 27, 2020

I will update the KEP format as I have the opportunity to.

Yes, this is planned for 1.19. There will be some doc additions describing metrics for tracking deprecated API use.

@zestrells
Copy link

zestrells commented Jun 8, 2020

Hi @liggitt - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

@liggitt
Copy link
Member Author

liggitt commented Jun 8, 2020

opened placeholder at kubernetes/website#21581

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 17, 2020

Hi @liggitt !

To follow-up on the email sent to k-dev on Monday, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19
We expect all PRs to be merged by that time. Please let me know if you have any questions. 😄

Best,

Kirsten

@palnabarun
Copy link
Member

palnabarun commented Jun 28, 2020

Hi @liggitt 👋, is kubernetes/kubernetes#92329 the only implementation PR for this feature? If not, can you please link here all the other implementation PRs?

Thank you. 🙂

@liggitt
Copy link
Member Author

liggitt commented Jun 29, 2020

@palnabarun
Copy link
Member

palnabarun commented Jul 1, 2020

@liggitt -- Thank you for the updates. 🙂

@palnabarun
Copy link
Member

palnabarun commented Jul 6, 2020

Hi @liggitt 👋, I saw that all the implementation PRs mentioned above have been merged. Can we consider the work complete for this milestone?

Thank you. 🙂

@liggitt
Copy link
Member Author

liggitt commented Jul 6, 2020

One last impl PR at kubernetes/kubernetes#92842

The doc PR is ready for review

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 9, 2020

Hi @liggitt

Will the above PR get merge by EOD today? Today is code freeze.

Thanks!

@liggitt
Copy link
Member Author

liggitt commented Jul 9, 2020

That depends on how the merge queue makes progress. It is reviewed and approved and in the milestone, so it will merge as the queue drains.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 9, 2020

@liggitt I double checked and we have several fully approved, properly tagged, etc.. that are stuck in the merge pool. They will be considered making the deadline and we'll be following their progress closely.

Thanks for the update!

Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jul 12, 2020

@liggitt kubernetes/kubernetes#92842 finally merged! I will update the enhancements tracking sheet to reflect this. Congrats!

@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 12, 2021
@fejta-bot
Copy link

fejta-bot commented Feb 11, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 11, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt reopened this Apr 29, 2021
@liggitt liggitt added this to the v1.22 milestone Apr 29, 2021
@liggitt liggitt added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Apr 29, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 29, 2021
@gracenng
Copy link
Member

gracenng commented May 9, 2021

Hi @liggitt 👋 1.22 Enhancements Shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • Please up date your kep.yaml file with the latest template
  • I was unable to find the PRR for this enhancements so it will be marked as PRR not approved

Thanks!

@gracenng
Copy link
Member

gracenng commented May 11, 2021

Hi @liggitt 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-api-machinery will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@liggitt
Copy link
Member Author

liggitt commented May 11, 2021

#2719 open to update KEP with milestone and add PRR answers

@liggitt
Copy link
Member Author

liggitt commented May 11, 2021

I just wanted to double check to see if SIG-api-machinery will need to do anything for this enhancement and if so, are they OK with it?

The KEP/PRR work is complete and merged:

The implementation PRs are pending review:

@PI-Victor
Copy link
Member

PI-Victor commented May 18, 2021

Heya @liggitt Docs release lead for 1.22 here, this KEP did not opt-in for docs changes for 1.22, however, and please correct me if i'm wrong, it seems that one of you PRs marks WarningHeaders as GA, this would mean that the feature gates table in the docs needs to reflect that change.
If that is true, could you or someone from the SIG open a PR against the k/website dev-1.22 branch to make this change?

thank you!

@liggitt
Copy link
Member Author

liggitt commented May 18, 2021

sure, kubernetes/website#28032

@gracenng
Copy link
Member

gracenng commented Jun 23, 2021

Hi @liggitt 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, are k/k#101688 and k/k#100754 the only PRs for this enhancements?

Thank you!

@liggitt
Copy link
Member Author

liggitt commented Jun 23, 2021

yes

@jsoref jsoref mentioned this issue Aug 8, 2021
@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 12, 2021
@salaxander
Copy link

salaxander commented Aug 18, 2021

Hey @liggitt - Would you be able to open a PR on the KEP to change the stage to implemented? At that point we'll be able to close out the issue. :)

Thanks!

@liggitt
Copy link
Member Author

liggitt commented Aug 18, 2021

opened #2875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.