Container Resources CRI API Changes for Pod Vertical Scaling

[shekhar-rajak]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Container Resources CRI API Changes for Pod Vertical Scaling

• Kubernetes Enhancement Proposal:

After merging #2266, we will get the file location: "/keps/sig-node/2273-kubelet-container-resources-cri-api-changes"

• Discussion Link: In-Place Vertical Pod Scaling KEP to implementable, and mini-KEP for CRI extensions #1342

• Primary contact (assignee):

  • "@vinaykul"
  • "@quinton-hoole"

• Responsible SIGs: sig-node

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y):
  • Beta release target (x.y):
  • Stable release target (x.y):

• Alpha

  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

Alpha

• UpdateContainerResources and ContainerStatus API changes are done and tested
  with dockershim and docker runtime, backward compatibility is maintained.

Beta

• UpdateContainerResources and ContainerStatus API changes are completed and
  tested for Windows runtime.

Stable

• No major bugs reported for three months.

Implementation History

• 2019-10-25 - Initial KEP draft created
• 2020-01-14 - Test plan and graduation criteria added
  Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[shekhar-rajak]

/sig node

[shekhar-rajak]

We need to update the "Enhancement target" and in the proposal as well.

[ehashman]

/sig autoscaling

[vinaykul]

We need to update the "Enhancement target" and in the proposal as well.

@shekhar-rajak Thanks for migrating the KEP to the new format (I apologize for being unresponsive about it). Could you please clarify what Enhancement target refers to here, and where should we make the update?

@thockin and I have been working on updating the design changes to the main KEP and I believe we have reached a consensus. Consequently, I reviewed the CRI KEP for potential changes. Besides the issue of dockershim deprecation and it's potential impact on alpha test criteria that I need to investigate closely, nothing in particular stands out as needing update.

I'm looking to target both KEPS for 1.21 release at this time, the estimate might change depending on my assessment of how much the codebase has evolved since my earlier implementation last summer.

/cc @kikisdeliveryservice

[kikisdeliveryservice]

Hi @vinaykul !

Enhancements freeze has passed and this KEP is not tracked/was not opted in. You'll need to discuss with the sponsoring SIGs and if they agree, submit an Exception Request ASAP to be included in the 1.21 release.

cc: @annajung

[ehashman]

/stage alpha
/milestone v1.22

ref #2474

[supriya-premkumar]

👋🏽 Hi @vinaykul

This is Supriya, v1.22 enhancement shadow here. For the enhancement to be included in the 1.22 milestone, it must meet the following criteria:

The KEP must have a production readiness review
The KEP must have graduation criteria
The KEP must have targeted/latest milestone mentioned in kep.yaml

Please make sure to follow all the instructions and update the KEP to include this.

Thank you!

[supriya-premkumar]

👋🏽 Hi @vinaykul @ehashman

This is Supriya, v1.22 enhancement shadow. After reviewing the KEP and PRR. This enhancement is now being tracked for the 1.22 milestone.

[Done] The KEP must have a production readiness review
[Done] The KEP must have graduation criteria
[Done] The KEP must have targeted/latest milestone mentioned in kep.yaml

Thank you!

[vinaykul]

@supriya-premkumar I'll get to the documentation PR by next week.

The implementation PR (work in progress) for this KEP is kubernetes/kubernetes#102884 and is out for review.

There are two KEPs for this feature. Please also track the KEP in the issue #1287 alongside this KEP issue. They both go in or none of them do.

[supriya-premkumar]

Hi @vinaykul, just a reminder that we are one week away from the code freeze(July 8th, 2021) and I see that the PR is yet to be merged, due to this the issue will still be marked as atRisk for the 1.22 Release. Also, the Doc Placeholder PR deadline is on July 9th, 2021.

[supriya-premkumar]

Hi @vinaykul, I just wanted to send a reminder that we have just 1 more day to get all the remaining PRs merged before the code freeze deadline tomorrow on Thursday, July 8th at 18:00 Pacific Time.

[JamesLaverack]

Hi, v1.22 Enhancements Lead here. Unfortunately this enhancement has not met the requirements for code freeze as kubernetes/kubernetes#102884 is unmerged and unapproved.

If you still wish to progress this enhancement in v1.22, then please file an exception request.

/milestone clear

[ehashman]

/milestone v1.23
Per Node KEP Planning -- high priority

Required alongside #1287 (not sure why this is a separate KEP)

[salaxander]

Hi @vinaykul! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like we're all set for enhancements freeze!

Thanks!

[jlbutler]

@vinaykul @ehashman 1.23 Docs team here 👋

This enhancement issue is listed as 'None required' for docs in the tracking sheet. Will docs related to these API changes be covered by docs PR(s) related to #1287 ? Just making sure we're tracking the right things. Thanks!

[vinaykul]

@vinaykul @ehashman 1.23 Docs team here 👋

This enhancement issue is listed as 'None required' for docs in the tracking sheet. Will docs related to these API changes be covered by docs PR(s) related to #1287 ? Just making sure we're tracking the right things. Thanks!

Yes. This KEP was created mainly to have a separate discussion track with a different focus group of people and avoid churn on 1287. 1278 depends on this and doc updates to 1287 will cover this.

[ehashman]

If we don't have a separate PR for the CRI changes, can we merge the design proposal into #1287 and close the issue? I see this has been rolled up into kubernetes/kubernetes#102884 so there's no point in tracking it separately

[salaxander]

Hey @ehashman and @vinaykul - is the plan now to merge this into #1287? Just curious for 1.23 enhancements tracking purposes :)

[vinaykul]

@salaxander Let's just keep it the way it is for now, I'm way too busy and don't need another housekeeping item tacked on.

[salaxander]

Hey @ehashman and @vinaykul - Looks like we're still waiting on kubernetes/kubernetes#102884 to merge for this one? Today is code freeze so I have this enhancement marked as at-risk currently. If all associated PRs merge to k/k before 6pm PT tonight we're good

[salaxander]

Hi, 1.23 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

• All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[vinaykul]

/close

KEP 2273 is being merged with KEP 1287 and tracked by issue #1287

[k8s-ci-robot]

@vinaykul: Closing this issue.

In response to this:

/close

KEP 2273 is being merged with KEP 1287 and tracked by issue #1287

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.