New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support memory qos with cgroups v2 #2570
Comments
/sig node |
/assign @xiaoxubeii |
Hi! This sounds really interesting and I'd love to help out, please let me know how I can help out with this! |
/stage alpha |
Hi @xiaoxubeii 👋 1.22 Enhancements Shadow here. This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:
Thanks! |
Hi @xiaoxubeii 👋 1.22 Enhancements shadow here. To help SIG's be aware of their workload, I just wanted to check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it? |
@gracenng Hey grace, I have updated necessary contents as follows:
sig-node approvers @derekwaynecarr @mrunalp are reviewing for that. I am waiting for lgtm/approve and merge as |
@gracenng sig-node approvers(Derek and Mrunal) have gave lgtm/approve. There are few prr review requests, I have updated and am waiting for next review round. I think we can catch up with the freeze day :) |
Hi @xiaoxubeii , looks like your PRR was approved and the requested changes are all here. I have updated the status of this enhancement to |
Thanks for your help. Also thanks very much to a lot of valuable review suggestions and helps from @derekwaynecarr @mrunalp @bobbypage @giuseppe @odinuge @johnbelamaric @ehashman |
Hello @xiaoxubeii 👋 , 1.22 Docs Shadow here. This enhancement is marked as Needs Docs for 1.22 release. Thank you! |
@ritpanjw OK, thanks for reminding. |
Hi @xiaoxubeii 🌞 1.22 enhancements shadow here. In light of Code Freeze on July 8th, this enhancement current status is Please let me know if there is other code PR associated with this enhancement. Thanks |
@gracenng It is all here, thanks. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
I opened kubernetes/website#40513 and I will update it ASAP. |
as per the sig node meeting on 5/2/2023 this will be worked on in 1.28 /milestone v1.28 |
/stage beta |
/label lead-opted-in |
Hi @xiaoxubeii 👋, Enhancements team here! Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following: The status of this enhancement is marked as |
Thanks @npolshakova for bringing this up. This KEP is targeting beta in 1.28. I will go ahead and take care of the action items here on Monday. cc: @xiaoxubeii |
Please be sure to update the PRR questions for beta. |
Hi @xiaoxubeii 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023. The status for this enhancement is For this KEP, we would just need to update the following:
Let me know if I missed anything. Thanks! |
@npolshakova this should be good for 1.28 now |
Hey @xiaoxubeii 1.28 Docs Shadow here. Does this enhancement work planned for 1.28 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Hey again @xiaoxubeii 👋 Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:
For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences : Also please let me know if there are other PRs in k/k we should be tracking for this KEP. |
Hey @xiaoxubeii , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023. |
Thanks for @ndixita detailed test: https://docs.google.com/document/d/1mY0MTT34P-Eyv5G1t_Pqs4OWyIH-cg9caRKWmqYlSbI/edit?usp=sharing. 🚨🚨 Sometimes the application pod is stuck for throttling memory. This is a worse behavior than OOM kill. See kubernetes/kubernetes#118699 (comment) as well. So KEP needs an update. |
Hello @ndixita @pacoxu with reference to above comment, I am removing this KEP from the current milestone. |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):The text was updated successfully, but these errors were encountered: