Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote memory qos to beta #41655

Closed
wants to merge 2 commits into from
Closed

Conversation

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2023
@Shubham82
Copy link
Contributor

put on hold until k8s/k8s #118699 will merge.

/hold

Please remove the hold label once the above PR will merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2023
Co-authored-by: Shubham <shubham.kuchhal@india.nec.com>
@Shubham82
Copy link
Contributor

Thanks, @pacoxu
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 788cc22f124b8c36d239c03f9ede438af6a8769f

@windsonsea
Copy link
Member

Thanks.
/lgtm

@tengqm
Copy link
Contributor

tengqm commented Jun 17, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2023
@sftim
Copy link
Contributor

sftim commented Jul 24, 2023

Is this change still needed for v1.28?

@sftim
Copy link
Contributor

sftim commented Jul 24, 2023

Because kubernetes/kubernetes#118699 is marked as postponed:
/approve cancel

Feel free to re-approve if context shows that's the right thing to do.

@pacoxu
Copy link
Member Author

pacoxu commented Jul 24, 2023

Is this change still needed for v1.28?

No, we decided to postpone the promotion due to a throttling problem that will make application stuck and no successful response later( which is worse than immediately oom kill).

@pacoxu
Copy link
Member Author

pacoxu commented Jul 24, 2023

/close
I will open another one if we want to promote it later.

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closed this PR.

In response to this:

/close
I will open another one if we want to promote it later.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants