-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote memory qos to beta #41655
promote memory qos to beta #41655
Conversation
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
put on hold until k8s/k8s #118699 will merge. /hold Please remove the hold label once the above PR will merge. |
Co-authored-by: Shubham <shubham.kuchhal@india.nec.com>
Thanks, @pacoxu |
LGTM label has been added. Git tree hash: 788cc22f124b8c36d239c03f9ede438af6a8769f
|
Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this change still needed for v1.28? |
Because kubernetes/kubernetes#118699 is marked as postponed: Feel free to re-approve if context shows that's the right thing to do. |
No, we decided to postpone the promotion due to a throttling problem that will make application stuck and no successful response later( which is worse than immediately oom kill). |
/close |
@pacoxu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2570-memory-qos: kubernetes/enhancements#2570