Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: the documentation for the matchLabelKeys in PodAffinity #39779

Closed

Conversation

sanposhiho
Copy link
Member

It's a placeholder

ref: kubernetes/enhancements#3633

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Mar 4, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b2b3922
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6403077c4779ff00087c6c44
😎 Deploy Preview https://deploy-preview-39779--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@yashdev9274 yashdev9274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an empty commit.

I request to close it

@sanposhiho
Copy link
Member Author

As described, it's just a placeholder now. The release team told me to create the placeholder PR for the documentation of the new feature.

@sanposhiho
Copy link
Member Author

sanposhiho commented Mar 6, 2023

I couldn't have time to write the doc yet, but will back here by the doc freeze.

@mickeyboxell
Copy link
Contributor

Hi @sanposhiho 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@sanposhiho
Copy link
Member Author

Sorry, this enhancement was postponed in next release.
Let me close it

/close

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: Closed this PR.

In response to this:

Sorry, this enhancement was postponed in next release.
Let me close it

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants