New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure Virtual Machine Scale Sets #513

Closed
feiskyer opened this Issue Nov 16, 2017 · 20 comments

Comments

Projects
None yet
9 participants
@feiskyer
Member

feiskyer commented Nov 16, 2017

Feature Description

  • One-line feature description (can be used as a release note): Add support for Azure Virtual Machine Scale Sets (VMSS).
  • Primary contact (assignee): @feiskyer
  • Responsible SIGs: sig-azure
  • Design proposal link (community repo): kubernetes/kubernetes#43287
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @brendandburns @colemickens
  • Approver (likely from SIG/area to which feature belongs): @brendandburns @colemickens
  • Feature target (which target equals to which milestone):
    • Alpha release target v1.10
    • Beta release target v1.11
    • Stable release target v1.12
@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 15, 2018

@feiskyer @kubernetes/sig-azure-misc still on track for 1.10?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Jan 15, 2018

@idvoretskyi Yep, this is targeted for 1.10

@feiskyer feiskyer modified the milestones: next-milestone, v1.10 Jan 15, 2018

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

/kind feature

@danigian

This comment has been minimized.

danigian commented Mar 21, 2018

Are you planning to introduce support for Low-Priority VMs on VMSS?
In my opinion it would enable really interesting scenarios

@feiskyer

This comment has been minimized.

Member

feiskyer commented Mar 22, 2018

@danigian Yep, I think so. Let me check this after v1.10 release.

@feiskyer feiskyer modified the milestones: v1.10, v1.11 Mar 27, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@feiskyer
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@feiskyer feiskyer added stage/beta and removed stage/alpha labels Apr 17, 2018

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@feiskyer please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

@feiskyer -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Jun 5, 2018

@justaugustus Already updated. Thanks

@feiskyer feiskyer modified the milestones: v1.11, v1.12 Jul 11, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@feiskyer --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @feiskyer I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@feiskyer --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@feiskyer

This comment has been minimized.

Member

feiskyer commented Sep 6, 2018

@justaugustus Yep, still tracked for v1.12. No docs are needed.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 6, 2018

Thanks for the update!

@djsly

This comment has been minimized.

djsly commented Sep 13, 2018

@feiskyer would you have a list of items still needed to VMSS with k8s ?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Sep 13, 2018

@djsly No, I think the feature has been finished and could be closed after v1.12 release. Do you have additional ideas on this?

@djsly

This comment has been minimized.

djsly commented Sep 13, 2018

I'm about to spin up Staging clusters with 1.11.3 so I will know more in the coming weeks :)
Right now, most of my concerns are with VM Extension error handling with cluster autoscaler. But that's out of scope for here, we can take it offline :)

@feiskyer

This comment has been minimized.

Member

feiskyer commented Sep 14, 2018

@djsly Could you open an issue for it on autoscaler repo?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Sep 28, 2018

GA and done now. Let's close it.

/close

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Sep 28, 2018

@feiskyer: Closing this issue.

In response to this:

GA and done now. Let's close it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment