New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology aware routing of services #536

Open
m1093782566 opened this Issue Jan 11, 2018 · 30 comments

Comments

@m1093782566
Copy link
Member

m1093782566 commented Jan 11, 2018

Feature Description

  • One-line feature description (can be used as a release note):
    Implement "local service", say "topology aware routing of service". Local means "same topology level", e.g. same node, same rack, same failure zone, same failure region and whatever users like.

  • Primary contact (assignee):
    @m1093782566

  • Responsible SIGs:
    /sig network

  • Design proposal link (community repo):
    #640

  • Link to e2e and/or unit tests:

  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @thockin @quinton-hoole @kevin-wangzefeng

  • Approver (likely from SIG/area to which feature belongs):
    @thockin

  • Feature target (which target equals to which milestone):

    • Alpha release target (1.15)
    • Beta release target (x.y)
    • Stable release target (x.y)

PRs

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jan 11, 2018

/assign

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jan 12, 2018

After discussing in today's sig-network meeting, we are targeting it Alpha in v1.10.

cc @kubernetes/sig-network-misc

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Mar 5, 2018

The design discussion has not been resolved, this looks like now targeted for v1.11? Please update if not so.

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Mar 6, 2018

It seems we have missed the v1.10 time window. I will present it on next SIG-Network meeting to see if it can get a v1.11 ticket?

@caseydavenport caseydavenport modified the milestones: v1.10, v1.11 Mar 7, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

@m1093782566
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@justaugustus justaugustus removed this from the v1.11 milestone Apr 29, 2018

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jul 28, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jul 28, 2018

/remove-lifecycle stale

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jul 28, 2018

/wg policy

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 30, 2018

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 8, 2018

Hi @m1093782566
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post or take the opportunity to develop a KEP.

Thanks!

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

johnbelamaric commented Oct 9, 2018

Per sig-network we are looking at getting a revised KEP in for the 1.13 timeframe but not the code.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 7, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jan 7, 2019

/remove-lifecycle stale

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 16, 2019

@m1093782566 Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jan 17, 2019

@claurence

Please check #640

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 17, 2019

@m1093782566 Thanks! Based on the description it sounds like this feature is targeting alpha in 1.15 so there is nothing to track for 1.14 but let me know if that is not correct

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

johnbelamaric commented Jan 17, 2019

@claurence We were hoping for alpha in 1.14 if we can get it in. @m1093782566 do you think that you will finish the CRD rework in time for 1.14?

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 17, 2019

Thanks @johnbelamaric - do you have any open PRs for this issue for it to make the alpha milestone?

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

johnbelamaric commented Jan 17, 2019

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jan 18, 2019

@claurence We were hoping for alpha in 1.14 if we can get it in. @m1093782566 do you think that you will finish the CRD rework in time for 1.14?

I will try.

@claurence claurence added this to the v1.14 milestone Jan 22, 2019

@claurence claurence added tracked/yes and removed tracked/no labels Jan 22, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 11, 2019

@m1093782566 @johnbelamaric Hello - we've noticed the KEP for this issue is still marked as "pending" - what more is needed to make the KEP implementable?

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

johnbelamaric commented Feb 11, 2019

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Feb 12, 2019

@johnbelamaric

Thanks. I am not sure if we can make the 1.14 code freeze date but I am working on it now.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 15, 2019

/assign @thockin
for API review

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 15, 2019

@vishh shadow

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 19, 2019

@johnbelamaric @m1093782566 @thockin can one of you please PR the KEP to implementable status? ref: #536 (comment)

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

johnbelamaric commented Feb 19, 2019

done in #845

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

johnbelamaric commented Feb 21, 2019

@claurence this has been retargeted to 1.15. Can you reassign it (I don't have permissions)?

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 21, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.14, v1.15 Feb 21, 2019

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Feb 21, 2019

I am interested in shadowing the API review for this... next quarter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment