Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology aware routing of services #536

Closed
1 task
m1093782566 opened this issue Jan 11, 2018 · 102 comments
Closed
1 task

Topology aware routing of services #536

m1093782566 opened this issue Jan 11, 2018 · 102 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/policy Categorizes an issue or PR as relevant to WG Policy.
Milestone

Comments

@m1093782566
Copy link

m1093782566 commented Jan 11, 2018

Feature Description

PRs

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 11, 2018
@m1093782566
Copy link
Author

m1093782566 commented Jan 11, 2018

/assign

@m1093782566
Copy link
Author

m1093782566 commented Jan 12, 2018

After discussing in today's sig-network meeting, we are targeting it Alpha in v1.10.

cc @kubernetes/sig-network-misc

@kevin-wangzefeng kevin-wangzefeng added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 12, 2018
@kevin-wangzefeng kevin-wangzefeng added this to the v1.10 milestone Jan 12, 2018
@idvoretskyi idvoretskyi added kind/feature Categorizes issue or PR as related to a new feature. tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 29, 2018
@bowei
Copy link
Member

bowei commented Mar 5, 2018

The design discussion has not been resolved, this looks like now targeted for v1.11? Please update if not so.

@m1093782566
Copy link
Author

m1093782566 commented Mar 6, 2018

It seems we have missed the v1.10 time window. I will present it on next SIG-Network meeting to see if it can get a v1.11 ticket?

@caseydavenport caseydavenport modified the milestones: v1.10, v1.11 Mar 7, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

@m1093782566
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@justaugustus justaugustus removed this from the v1.11 milestone Apr 29, 2018
@fejta-bot
Copy link

fejta-bot commented Jul 28, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2018
@m1093782566
Copy link
Author

m1093782566 commented Jul 28, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2018
@m1093782566
Copy link
Author

m1093782566 commented Jul 28, 2018

/wg policy

@k8s-ci-robot k8s-ci-robot added the wg/policy Categorizes an issue or PR as relevant to WG Policy. label Jul 28, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 28, 2018
@justaugustus
Copy link
Member

justaugustus commented Jul 30, 2018

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus justaugustus added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 4, 2018
@kacole2
Copy link
Member

kacole2 commented Oct 8, 2018

Hi @m1093782566
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post or take the opportunity to develop a KEP.

Thanks!

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Oct 9, 2018

Per sig-network we are looking at getting a revised KEP in for the 1.13 timeframe but not the code.

@fejta-bot
Copy link

fejta-bot commented Jan 7, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019
@m1093782566
Copy link
Author

m1093782566 commented Jan 7, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019
@claurence
Copy link

claurence commented Jan 16, 2019

@m1093782566 Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 1, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 1, 2021

/remove-stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 1, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 May 1, 2021
@kikisdeliveryservice kikisdeliveryservice added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label May 10, 2021
@salaxander
Copy link

salaxander commented May 11, 2021

Hey @robscott - 1.22 enhancements team here! I've got a couple questions to clarify for the release. Is the current plan to postpone deprecation if #2433 doesn't end up making the release? Also, would you be able to update the kep.yaml to have latest-milestone: "v1.22" before enhancements freeze on 5/13?

@robscott
Copy link
Member

robscott commented May 11, 2021

Hey @salaxander, thanks for checking in! I think the only thing that's left to do for this enhancement in 1.22 is remove the code. I believe it was deprecated in the last cycle and #2433 went alpha in 1.21 as well. Since this feature only ever made it to alpha, I don't think we need to wait for #2433 to make it to alpha before removing this one (though #2433 may make it to beta in 1.22). With that said, does this still require the latest-milestone update if we're just removing the code?

@salaxander
Copy link

salaxander commented May 11, 2021

Thanks for the reply @robscott! @JamesLaverack, @annajung, or @kikisdeliveryservice, would you be able to confirm if we would still need the latest-milestone updated for the deprecation?

Thanks everyone! ☺️

@chino
Copy link

chino commented May 11, 2021

So #2433 is replacing this?

@robscott
Copy link
Member

robscott commented May 11, 2021

@chino yep, #2433 is replacing this one.

@jethrogb
Copy link

jethrogb commented May 11, 2021

It seems reasonable to me to keep this until #2433 hits alpha.

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 11, 2021

When it comes to it, feel free to assign me as PRR approver. Should be all N/A pretty much for PRR but the validations will kick in.

@robscott
Copy link
Member

robscott commented May 12, 2021

Sorry for the confusion on this one, I meant to say "I don't think we need to wait for #2433 to make it to beta". It's already in alpha and therefore can serve as a replacement for this since that's as far as this feature went.

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 12, 2021

I think it makes sense to update the latest-milestone to indicate that that is when the code was removed.

@PI-Victor
Copy link
Member

PI-Victor commented May 18, 2021

Heya @robscott, Docs release lead for 1.22, this KEP did not opt-in for docs changes for this release, however i have one question, does this KEP deprecate ServiceTopology feature gate? As i understand it, this would be replaced by Topology Aware Hints

Please correct me if i'm wrong, but I believe it needs to be moved in the documentation to the deprecated features table from the feature gates table where it currently resides.
If so, could you or a member of the team please open a PR to rectify that?

thank you!

@robscott
Copy link
Member

robscott commented May 18, 2021

Hey @PI-Victor, you're right that we'll need to update the docs to note that this feature has been deprecated. The API deprecation actually already happened in 1.21 and we'll be working on removing the functionality in 1.22: kubernetes/kubernetes#96736.

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 16, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2021
@george-angel
Copy link

george-angel commented Aug 17, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2021
@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@thockin
Copy link
Member

thockin commented Sep 3, 2021

@robscott Time to close this one?

@robscott
Copy link
Member

robscott commented Sep 3, 2021

Yep, I think so, looks like everything's been removed. @andrewsykim can probably correct me if I missed anything.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 3, 2021

@robscott: Closing this issue.

In response to this:

Yep, I think so, looks like everything's been removed. @andrewsykim can probably correct me if I missed anything.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/policy Categorizes an issue or PR as relevant to WG Policy.
Projects
Development

No branches or pull requests