-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3107: SecretRef field addition to NodeExpandVolume request #3173
Conversation
8bdafca
to
80d9656
Compare
keps/sig-storage/3107-csi-nodeexpandsecret.md/3107-csi-nodeExpandSecret.md
Outdated
Show resolved
Hide resolved
keps/sig-storage/3107-csi-nodeexpandsecret.md/3107-csi-nodeExpandSecret.md
Outdated
Show resolved
Hide resolved
keps/sig-storage/3107-csi-nodeexpandsecret.md/3107-csi-nodeExpandSecret.md
Outdated
Show resolved
Hide resolved
keps/sig-storage/3107-csi-nodeexpandsecret.md/3107-csi-nodeExpandSecret.md
Outdated
Show resolved
Hide resolved
Can you also add the PRR file so we can get a PRR reviewer? |
@humblec Can you remove ".md" from the middle part of the directory "3107-csi-nodeexpandsecret.md" and rename 3107-csi-nodeExpandSecret.md to README.md? See this example here: |
1135788
to
dbdc267
Compare
Added PRR file @msau42 , ptal.. |
Sure, the file name schema is corrected . thanks @xing-yang |
Cc @gnufied |
@humblec the PRR file is still missing. See https://github.com/kubernetes/enhancements/pull/3151/files as an example. |
Sure, added. Thanks @msau42 .. ptal. |
/assign @deads2k |
7eb5e32
to
b50ac0d
Compare
f652415
to
be97117
Compare
Issue kubernetes#3107 Other comments: Prototype with working implementation kubernetes/kubernetes#105963 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
/lgtm |
|
||
TBD | ||
|
||
### Monitoring Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not required for alpha, I encourage you to think about what metrics you'll need to build for beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure , Thanks @deads2k 👍
monitoring and troubleshooting are often the hardest parts to fill in for a transition to beta. I encourage you to think about how you will handle it during your alpha. PRR is complete for alpha /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, humblec, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#32450 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#32450 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
csi: add nodeExpandSecret support for CSI client & add unit test kubernetes#105963
Signed-off-by: Humble Chirammal hchiramm@redhat.com