csi: add nodeExpandSecret KEP details #35334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
sig/docs
|
Cc @xing-yang @sftim |
sftim
reviewed
Jul 25, 2022
|
/assign |
sftim
reviewed
Jul 27, 2022
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
|
@sftim do we need to get this merged before any deadline ? |
|
The deadline for merge is the v1.25 release date. However, there is also a deadline for having PRs ready to review (which is this week, I think). |
12 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9a736fc4bbf323d889320c9c91a4f1671923fff9
|
|
I believe this is good to go. Lift the hold if that is true. |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@tengqm LGTM too, any improve or we can remomve the hold? |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: #33979
Signed-off-by: Humble Chirammal hchiramm@redhat.com