Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update non-graceful node shutdown to beta #3320

Merged
merged 7 commits into from Oct 3, 2022
Merged

Update non-graceful node shutdown to beta #3320

merged 7 commits into from Oct 3, 2022

Conversation

xing-yang
Copy link
Contributor

  • One-line PR description: Move non-graceful node shutdown feature to beta.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 28, 2022
@xing-yang
Copy link
Contributor Author

/assign @jingxu97 @gnufied

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2022
@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch from 765f51c to be9404f Compare May 28, 2022 14:09
@xing-yang
Copy link
Contributor Author

/assign @deads2k

@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch from be9404f to 5971fee Compare June 5, 2022 01:09
@palnabarun
Copy link
Member

/uncc

(I probably got auto-assigned)

@k8s-ci-robot k8s-ci-robot removed the request for review from palnabarun June 6, 2022 09:20
@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch 2 times, most recently from 45e91ad to f9442d1 Compare June 9, 2022 00:50
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 11, 2022
Closed
@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch from f9442d1 to b77d18f Compare June 14, 2022 02:03
@YuikoTakada
Copy link
Contributor

This PR needs milestone v1.26 label?

@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch from e971c58 to b853649 Compare September 12, 2022 22:51
@xing-yang
Copy link
Contributor Author

@YuikoTakada Thanks for your review. I've addressed your comments. Yes, this PR needs a lgtm.

@YuikoTakada
Copy link
Contributor

/milestone v1.26

@k8s-ci-robot
Copy link
Contributor

@YuikoTakada: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuikoTakada
Copy link
Contributor

@xing-yang Thank you for updating. It looks to me.
Could you please add milestone v1.26 label to this PR? It seems that I don't have the right.

@xing-yang
Copy link
Contributor Author

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 19, 2022
@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch from b853649 to 9033f6f Compare September 20, 2022 01:30
@xing-yang
Copy link
Contributor Author

@msau42 Addressed your comments. Thanks.

@msau42 msau42 linked an issue Sep 20, 2022 that may be closed by this pull request
Non-graceful node shutdown #2268
Closed
@xing-yang
Copy link
Contributor Author

@msau42 @gnufied, the e2e test is in the testgrid now. PTAL.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/112790/pull-kubernetes-e2e-gce-alpha-features/1575514848412831744/

Kubernetes e2e suite: [It] [sig-storage] [Feature:NodeOutOfServiceVolumeDetach] [Disruptive] [LinuxOnly] NonGracefulNodeShutdown [NonGracefulNodeShutdown] pod that uses a persistent volume via gce pd driver should get immediately rescheduled to a different node after non graceful node shutdown | 3m37s
-- | --

@xing-yang xing-yang force-pushed the non-graceful-node-shutdown-beta branch from 44139f8 to bc19dea Compare October 3, 2022 15:07
@jingxu97
Copy link
Contributor

jingxu97 commented Oct 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 30f3b92 into kubernetes:master Oct 3, 2022
@YuikoTakada YuikoTakada mentioned this pull request Oct 19, 2022
Merged
@carlory carlory mentioned this pull request May 24, 2023
Merged
@xing-yang xing-yang mentioned this pull request Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@deads2k deads2k deads2k left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

@deads2k deads2k

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Non-graceful node shutdown
10 participants
@xing-yang @k8s-triage-robot @palnabarun @deads2k @k8s-ci-robot @Priyankasaggu11929 @YuikoTakada @jingxu97 @gnufied @msau42