Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeOutOfServiceVolumeDetach feature update to GA #41302

Merged
merged 1 commit into from Aug 2, 2023
Merged

NodeOutOfServiceVolumeDetach feature update to GA #41302

merged 1 commit into from Aug 2, 2023

Conversation

carlory
Copy link
Member

@carlory carlory commented May 24, 2023 •
edited

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone May 24, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 24, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2023
@carlory carlory mentioned this pull request May 24, 2023
Closed
@Shubham82
Copy link
Contributor

thanks, @carlory
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5fb95c76631824e96d563391e76b0681a82ed4cb

@Shubham82
Copy link
Contributor

It can be merged after the PR:#118228
/hold

Please remove the hold label once the above PR will merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@YuikoTakada
Copy link
Contributor

Thank you for your PR.
https://github.com/kubernetes/website/blob/main/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md seems need to be updated also.

@carlory
Copy link
Member Author

carlory commented May 25, 2023 •
edited

This doc should only contain removed feature-gates. But the NodeOutOfServiceVolumeDetach still exists in 1.28.

@YuikoTakada
Copy link
Contributor

This doc should only contain removed feature-gates. But the NodeOutOfServiceVolumeDetach still exists in 1.28.

Thank you for your reply. It was my misunderstanding, sorry. You don't need to update https://github.com/kubernetes/website/blob/main/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md . Thanks.

@YuikoTakada
Copy link
Contributor

Upstream: kubernetes/kubernetes#118228
KEP: kubernetes/enhancements#3320

nit: correct KEP is kubernetes/enhancements#4029 ?

@carlory
Copy link
Member Author

carlory commented May 30, 2023

Thanks! It's updated.

@xing-yang
Copy link
Contributor

/assign

@carlory
Copy link
Member Author

carlory commented Jul 16, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2023
@xing-yang
Copy link
Contributor

/lgtm

@carlory
Copy link
Member Author

carlory commented Jul 18, 2023

/assign @onlydole

@sftim
Copy link
Contributor

sftim commented Jul 24, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 24, 2023
sftim
sftim reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
for docs

content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit efbe80a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64be11c245636c0008355ced

@carlory @sftim
NodeOutOfServiceVolumeDetach feature update to GA
efbe80a 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@carlory
Copy link
Member Author

carlory commented Jul 24, 2023

@sftim @xing-yang please review again

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jul 24, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jul 24, 2023
@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ebdfe8217de308440a78e9b18a162e7cec772b8

@carlory
Copy link
Member Author

carlory commented Jul 25, 2023

/assign @onlydole

@kbhawkey
Copy link
Contributor

kbhawkey commented Aug 2, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit d6857a1 into kubernetes:dev-1.28 Aug 2, 2023
7 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Aug 2, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#41302 from carlory/patch-100
7b8f8c6 
NodeOutOfServiceVolumeDetach feature update to GA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@natalisucks natalisucks Awaiting requested review from natalisucks

@onlydole onlydole Awaiting requested review from onlydole

@sftim sftim Awaiting requested review from sftim

@Shubham82 Shubham82 Awaiting requested review from Shubham82

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@onlydole onlydole

@xing-yang xing-yang

@sftim sftim

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@carlory @Shubham82 @k8s-ci-robot @YuikoTakada @xing-yang @sftim @kbhawkey @onlydole