Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2371: update criteria for alpha #3353

Merged
merged 2 commits into from
Jun 16, 2022
Merged

KEP-2371: update criteria for alpha #3353

merged 2 commits into from
Jun 16, 2022

Conversation

haircommander
Copy link
Contributor

@haircommander haircommander commented Jun 7, 2022 •
edited

Signed-off-by: Peter Hunt pehunt@redhat.com

  • One-line PR description: update criteria for alpha
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2022
@haircommander haircommander changed the title KE- 2371: update target for beta in 1.25 KEP-2371: update target for beta in 1.25 Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 7, 2022
@haircommander haircommander changed the title KEP-2371: update target for beta in 1.25 KEP-2371: update criteria for alpha Jun 13, 2022
@haircommander
KEP 2371: move some beta criteria to alpha criteria
e85591e 
and move the KEP stage to alpha, as more work is needed before the KEP can be considered alpha

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Contributor Author

I have pivoted. I don't think this KEP will be ready for beta. I think we should retarget at alpha, and update the alpha criteria to include broadcasting cAdvisor metrics from the CRI. That way, we can properly evaluate performance and stability in beta (once we have actual feedback on them). I would not consider this KEP at MVP stage without the cAdvisor metrics coming from somewhere, so I think it's better in alpha.

@bobbypage @mrunalp PTAL

@mrunalp
Copy link
Contributor

mrunalp commented Jun 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
rhockenbury
rhockenbury reviewed Jun 15, 2022
View reviewed changes
keps/sig-node/2371-cri-pod-container-stats/kep.yaml
status: implementable
stage: beta
latest-milestone: "v1.24"
stage: alpha
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is targeting beta in v1.25, right? If so, stage, latest-milestone and milestone.beta needs to reflect that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, this is an update to the alpha stage. It was originally targeting beta but I reconsidered

@haircommander
update test plan
11053a2 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2022
@haircommander haircommander mentioned this pull request Jun 15, 2022
Open
12 tasks
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 341d83b into kubernetes:master Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhockenbury rhockenbury rhockenbury left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haircommander @mrunalp @derekwaynecarr @k8s-ci-robot @rhockenbury