Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Dynamic Provisioning aka StorageClass #36

Closed
18 of 23 tasks
childsb opened this issue Jul 20, 2016 · 23 comments
Closed
18 of 23 tasks

Configurable Dynamic Provisioning aka StorageClass #36

childsb opened this issue Jul 20, 2016 · 23 comments
Assignees
@childsb @jsafrane @thockin
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
v1.6

Comments

@childsb
Copy link
Contributor

childsb commented Jul 20, 2016 •
edited by jsafrane
Loading

Description

The current dynamic provisioning feature supports only a single provisioner per cluster. This feature will allow multiple provisioners to be configured in a single cluster.

Progress Tracker

  • Before Alpha
    • Design Proposal.
    • Initial API review (if API). Maybe same PR as design doc. PR-NUMBER
      • Any code that changes an API (/pkg/apis/...)
      • cc @kubernetes/api
    • Identify shepherd (your SIG lead and/or kubernetes-pm@googlegroups.com will be able to help you). My Shepherd is: @childsb for now.
      • A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
      • The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.
    • Identify secondary/backup contact point. My Secondary Contact Point is: @saad-ali
      • Write (code + tests + docs) then get them merged. #29006
    • Code needs to be disabled by default. Verified by code OWNERS
    • Minimal testing
    • Minimal docs
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
      • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
    • Update release notes
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Before Stable

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@idvoretskyi idvoretskyi added this to the v1.4 milestone Jul 21, 2016
@idvoretskyi idvoretskyi added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Aug 4, 2016
@thockin thockin mentioned this issue Aug 18, 2016
Merged
@thockin thockin self-assigned this Aug 18, 2016
@wongma7 wongma7 mentioned this issue Aug 19, 2016
Merged
@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

@childsb @thockin I saw the docs box is checked, please update docs PR numbers also

@childsb
Copy link
Contributor Author

childsb commented Sep 2, 2016

@janetkuo we added examples showing the storageClass feature in action, are there additional doc requirements?

@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

In addition to examples, adding a user doc in https://github.com/kubernetes/kubernetes.github.io would be good too.

@childsb
Copy link
Contributor Author

childsb commented Sep 2, 2016

@janetkuo ack.. i'll get add a doc

@childsb
Copy link
Contributor Author

childsb commented Sep 2, 2016

@kubernetes/docs @janetkuo I knew we had a PR someplace. We can add more if needed: kubernetes/website#1064

@liggitt liggitt mentioned this issue Jan 9, 2017
Closed
11 tasks
@jsafrane
Copy link
Member

jsafrane commented Jan 9, 2017

Updated "Before stable" section with more detailed TODO list

@jsafrane jsafrane modified the milestones: v1.6, v1.4 Jan 9, 2017
@idvoretskyi
Copy link
Member

@jsafrane are you a person, responsible for the feature?

@jsafrane jsafrane self-assigned this Jan 11, 2017
@jsafrane
Copy link
Member

Yes, I am the responsible one.

@idvoretskyi idvoretskyi added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed (deprecated label - do not use) beta-in-1.4 labels Jan 12, 2017
@jsafrane jsafrane mentioned this issue Jan 17, 2017
Merged
@jsafrane
Copy link
Member

Removal of alpha annotation: kubernetes/kubernetes#40000

@jsafrane
Copy link
Member

New stable PV/PVC attributes: kubernetes/kubernetes#40013

@jsafrane
Copy link
Member

Issues to update of vSphere, Azure and Photon installation scripts to deploy a default storage class: kubernetes/kubernetes#40070, kubernetes/kubernetes#40071 and kubernetes/kubernetes#40072

GCE, AWS and OpenStack should already deploy one and no other platform had alpha provisioning enabled.

@jsafrane
Copy link
Member

storage.k8s.io/v1 API: kubernetes/kubernetes#40088

Now I have two PRs (kubernetes/kubernetes#40013 and kubernetes/kubernetes#40088) that need to get in before I actually start writing code to use v1 API in Kubernetes (controllers, examples, tests, ...) Please review.

@luomiao luomiao mentioned this issue Jan 31, 2017
Open
@kerneltime
Copy link

Is dashboard support part of this effort (if it has not already been addressed)

@philips
Copy link
Contributor

philips commented Feb 2, 2017

cc @lpabon

@jsafrane jsafrane mentioned this issue Feb 3, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Feb 16, 2017
Merge pull request #40000 from jsafrane/storage-ga-remove-alpha
8faa9b5 
Automatic merge from submit-queue

Remove alpha provisioning

This is the first part of kubernetes/enhancements#36

@kubernetes/sig-storage-misc 

**Release note**:
```release-note
Alpha version of dynamic volume provisioning is removed in this release. Annotation
"volume.alpha.kubernetes.io/storage-class" does not have any special meaning. A default storage class
and  DefaultStorageClass admission plugin can be used to preserve similar behavior of Kubernetes cluster,
see https://kubernetes.io/docs/user-guide/persistent-volumes/#class-1 for details.
```
@jsafrane
Copy link
Member

"alpha" provisioning has been removed, updating documentation at kubernetes/website#2557

@kerneltime kerneltime mentioned this issue Feb 22, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Feb 25, 2017
Merge pull request #41854 from vmware/default-storage-class.kerneltime
db2ba29 
Automatic merge from submit-queue (batch tested with PRs 41854, 41801, 40088, 41590, 41911)

Default storage class for vSphere Fixes #40070

**What this PR does / why we need it**:

Create default storage class for vSphere. This is part of the storage class GA effort kubernetes/enhancements#36

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

fixes #40070

**Special notes for your reviewer**:

**Release note**:

```release-note
```
@idvoretskyi
Copy link
Member

@childsb @jsafrane @thockin please, provide us with the release notes and documentation PR or link at https://docs.google.com/spreadsheets/d/1nspIeRVNjAQHRslHQD1-6gPv99OcYZLMezrBe3Pfhhg/edit#gid=0

Also, please, select the valid checkpoints at the Progress Tracker.

@jsafrane jsafrane mentioned this issue Mar 7, 2017
Merged
@jsafrane
Copy link
Member

jsafrane commented Mar 7, 2017

For the reference, alpha dynamic provisioning is not removed in 1.6, I did not want to rush it in one day before freeze. It will be removed in 1.7.

@jsafrane
Copy link
Member

jsafrane commented Mar 7, 2017

documentation: kubernetes/website#2686

@jsafrane
Copy link
Member

jsafrane commented Mar 7, 2017

examples: kubernetes/kubernetes#42637 (please review)

@jianglingxia jianglingxia mentioned this issue Sep 1, 2017
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2017
@gnufied
Copy link
Member

gnufied commented Dec 21, 2017

Is this an oversight to enable this bot on feature repository? A feature easily takes more than one release for implementation... @fejta

@fejta
Copy link

fejta commented Dec 22, 2017

Not an oversight. Please provide quarterly updates if this feature is still wanted

@luxas
Copy link
Member

luxas commented Dec 22, 2017 •
edited
Loading

This went GA in v1.6, let's close it.

@luxas luxas closed this as completed Dec 22, 2017
ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
@openshift-merge-robot
Merge pull request kubernetes#36 from huffmanca/csi-snapshot
f51f1a8 
Add CSI Snapshot support.
howardjohn pushed a commit to howardjohn/enhancements that referenced this issue Oct 21, 2022
@brian-avery
Fix YAML formatting and add link (kubernetes#36)
21e3d9b 
* Fix YAML formatting and add link

* Add features.yaml checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@childsb childsb

@jsafrane jsafrane

@thockin thockin

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests