CSI Cluster Registration Mechanism #594

saad-ali · 2018-07-27T23:58:25Z

Feature Description

One-line feature description (can be used as a release note): Introduce the ability for a CSI driver (optionally) to register it self with the Kubernetes API to:
- Make it easy for end users to discover CSI drivers installed on their cluster.
- Allow CSI drivers to customize how Kubernetes interacts with them (e.g. skip attach operation, etc.)
Primary contact (assignee): @saad-ali, @jsafrane
Responsible SIGs: /sig storage
Design proposal link (community repo): New: CSI Cluster Registration Mechanism #594 Old: Google doc
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin
Approver (likely from SIG/area to which feature belongs): @thockin
Feature target (which target equals to which milestone):
- Alpha release target (x.y): 1.12
- Beta release target (x.y): 1.14
- Stable release target (x.y): 1.15

justaugustus · 2018-07-28T08:58:28Z

Thanks for the update! This has been added to the 1.12 Tracking sheet.

zparnold · 2018-08-20T20:28:52Z

Hey there! @saad-ali I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@jsafrane

Automatic merge from submit-queue (batch tested with PRs 64283, 67910, 67803, 68100). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. CSI Cluster Registry and Node Info CRDs **What this PR does / why we need it**: Introduces the new `CSIDriver` and `CSINodeInfo` API Object as proposed in kubernetes/community#2514 and kubernetes/community#2034 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/enhancements#594 **Special notes for your reviewer**: Per the discussion in https://groups.google.com/d/msg/kubernetes-sig-storage-wg-csi/x5CchIP9qiI/D_TyOrn2CwAJ the API is being added to the staging directory of the `kubernetes/kubernetes` repo because the consumers will be attach/detach controller and possibly kubelet, but it will be installed as a CRD (because we want to move in the direction where the API server is Kubernetes agnostic, and all Kubernetes specific types are installed). **Release note**: ```release-note Introduce CSI Cluster Registration mechanism to ease CSI plugin discovery and allow CSI drivers to customize Kubernetes' interaction with them. ``` CC @jsafrane Kubernetes-commit: 85300f4f5dd7b0bd36d0538fb6c3255c06d5e6c2

@jsafrane

Automatic merge from submit-queue (batch tested with PRs 64283, 67910, 67803, 68100). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. CSI Cluster Registry and Node Info CRDs **What this PR does / why we need it**: Introduces the new `CSIDriver` and `CSINodeInfo` API Object as proposed in kubernetes/community#2514 and kubernetes/community#2034 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/enhancements#594 **Special notes for your reviewer**: Per the discussion in https://groups.google.com/d/msg/kubernetes-sig-storage-wg-csi/x5CchIP9qiI/D_TyOrn2CwAJ the API is being added to the staging directory of the `kubernetes/kubernetes` repo because the consumers will be attach/detach controller and possibly kubelet, but it will be installed as a CRD (because we want to move in the direction where the API server is Kubernetes agnostic, and all Kubernetes specific types are installed). **Release note**: ```release-note Introduce CSI Cluster Registration mechanism to ease CSI plugin discovery and allow CSI drivers to customize Kubernetes' interaction with them. ``` CC @jsafrane Kubernetes-commit: 85300f4f5dd7b0bd36d0538fb6c3255c06d5e6c2

saad-ali · 2018-09-07T20:47:56Z

These objects and registry are designed for CSI drivers authors. No documentation changes needed on kubernetes/website. Changes will be added to kubernetes-csi

claurence · 2018-10-05T17:01:25Z

Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

kacole2 · 2018-10-08T15:47:21Z

@saad-ali, @jsafrane just checking in from @claurence's post to see if this should be included for tracking. thanks!

kacole2 · 2018-10-15T13:47:04Z

/milestone v1.13

kacole2 · 2018-10-24T01:23:44Z

thanks for the updates @saad-ali

claurence · 2018-11-07T15:25:47Z

@saad-ali - Is there any work needed left to make this feature beta for 1.13? As an FYI Code slush is 11/9 and Code freeze is 11/15

kacole2 · 2018-11-07T22:47:37Z

@jsafrane are there any PRs we should be tracking as we approach slush? kubernetes/kubernetes#69462 and any others?

AishSundar · 2018-11-12T04:48:18Z

@jsafrane We are fast approaching Code freeze for 1.13 (11/6). I see kubernetes/kubernetes#69462 is still in active review. I also see atleast 3 more PRs referenced in kubernetes/kubernetes#69462? Are you confident of wrangling this by Wednesday this week giving us a couple of days to watch CI? If not please work with the release team to move this out to 1.14 sooner than later. thanks.

kacole2 · 2018-11-13T18:17:25Z

@jsafrane @hoegaarden @vladimirvivien There hasn't been any progress on kubernetes/kubernetes#69462 in a long time. Should we punt this out to 1.14?

msau42 · 2018-11-14T01:33:19Z

PR to add a CRD installation mechanism: kubernetes/kubernetes#70780

I just discussed with @saad-ali and @davidz627 and we decided we're going to keep this feature in alpha for this release. We want to focus on CSI GA instead.

msau42 · 2018-11-14T01:37:44Z

These are the tasks we need to do to go to beta:

Update known deployment tools to enable the CSI CRD install addon
Update addon to install v1beta1 CRDs (chicken and egg with [WIP] Move CSIDriver and CSINodeInfo objects to beta kubernetes#70367?)

AishSundar · 2018-11-14T01:53:34Z

@kacole2 to move this out of 1.13 for Beta. Thanks

AishSundar · 2018-11-14T01:55:59Z

@tfogo, @marpaia and @kbarnard10 to remove it from their updates respectively

kacole2 · 2018-11-14T14:53:22Z

/milestone clear

claurence · 2019-01-16T16:20:03Z

@saad-ali @jsafrane Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

jsafrane · 2019-01-18T17:46:37Z

@claurence, yes, we plan to move it to GA.

claurence · 2019-01-18T19:42:06Z

Thanks @jsafrane - any open PRs for this issue that we should track on the sheet?

claurence · 2019-01-25T22:34:21Z

@jsafrane great - do y'all have a KEP for this issue? We want all issues to have a KEP by enhancements freeze. Also are there any PRs we should track?

claurence · 2019-01-29T23:18:53Z

@jsafrane checking on a KEP for this issue - is there a PR open for a KEP?

msau42 · 2019-01-30T00:18:59Z

I discussed with @saad-ali and I don't think this needs to be a separate issue. This is defining a CRD that is used by two features:

Pass pod info to mount: Pass Pod information in CSI calls #603
Skip attach: Skip attach for non-attachable CSI volumes #770

The actual CRD installation mechanism is tracked by: #615

spiffxp · 2019-02-05T05:56:21Z

/milestone clear

saad-ali added this to the v1.12 milestone Jul 27, 2018

saad-ali added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 27, 2018

k8s-ci-robot assigned jsafrane and saad-ali Jul 28, 2018

justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 28, 2018

This was referenced Aug 14, 2018

CSI: support for in-line volumes in pods. kubernetes/community#2273

Closed

Proposal for CSI Cluster Registry kubernetes/community#2514

Closed

[WIP] CSI Cluster Registry kubernetes/kubernetes#67554

Closed

saad-ali mentioned this issue Aug 24, 2018

CSI Cluster Registry and Node Info CRDs kubernetes/kubernetes#67803

Merged

k8s-github-robot closed this as completed in kubernetes/kubernetes#67803 Aug 31, 2018

saad-ali reopened this Sep 7, 2018

bsalamat closed this as completed in bsalamat/kubernetes@85300f4 Sep 12, 2018

saad-ali reopened this Sep 15, 2018

kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 8, 2018

k8s-ci-robot modified the milestones: v1.12, v1.13 Oct 15, 2018

kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 15, 2018

saad-ali added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 24, 2018

k8s-ci-robot removed this from the v1.13 milestone Nov 14, 2018

kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 14, 2018

claurence added this to the v1.14 milestone Jan 22, 2019

claurence added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 22, 2019

saad-ali closed this as completed Jan 30, 2019

k8s-ci-robot removed this from the v1.14 milestone Feb 5, 2019

kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSI Cluster Registration Mechanism #594

CSI Cluster Registration Mechanism #594

saad-ali commented Jul 27, 2018 •

edited

Loading

justaugustus commented Jul 28, 2018

zparnold commented Aug 20, 2018

saad-ali commented Sep 7, 2018

claurence commented Oct 5, 2018

kacole2 commented Oct 8, 2018

kacole2 commented Oct 15, 2018

kacole2 commented Oct 24, 2018

claurence commented Nov 7, 2018

kacole2 commented Nov 7, 2018

AishSundar commented Nov 12, 2018

kacole2 commented Nov 13, 2018

msau42 commented Nov 14, 2018

msau42 commented Nov 14, 2018

AishSundar commented Nov 14, 2018

AishSundar commented Nov 14, 2018

kacole2 commented Nov 14, 2018

claurence commented Jan 16, 2019

jsafrane commented Jan 18, 2019

claurence commented Jan 18, 2019

claurence commented Jan 25, 2019

claurence commented Jan 29, 2019

msau42 commented Jan 30, 2019

spiffxp commented Feb 5, 2019

CSI Cluster Registration Mechanism #594

CSI Cluster Registration Mechanism #594

Comments

saad-ali commented Jul 27, 2018 • edited Loading

Feature Description

justaugustus commented Jul 28, 2018

zparnold commented Aug 20, 2018

saad-ali commented Sep 7, 2018

claurence commented Oct 5, 2018

kacole2 commented Oct 8, 2018

kacole2 commented Oct 15, 2018

kacole2 commented Oct 24, 2018

claurence commented Nov 7, 2018

kacole2 commented Nov 7, 2018

AishSundar commented Nov 12, 2018

kacole2 commented Nov 13, 2018

msau42 commented Nov 14, 2018

msau42 commented Nov 14, 2018

AishSundar commented Nov 14, 2018

AishSundar commented Nov 14, 2018

kacole2 commented Nov 14, 2018

claurence commented Jan 16, 2019

jsafrane commented Jan 18, 2019

claurence commented Jan 18, 2019

claurence commented Jan 25, 2019

claurence commented Jan 29, 2019

msau42 commented Jan 30, 2019

spiffxp commented Feb 5, 2019

saad-ali commented Jul 27, 2018 •

edited

Loading