-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI Cluster Registration Mechanism #594
Comments
Hey there! @saad-ali I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it? |
Automatic merge from submit-queue (batch tested with PRs 64283, 67910, 67803, 68100). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. CSI Cluster Registry and Node Info CRDs **What this PR does / why we need it**: Introduces the new `CSIDriver` and `CSINodeInfo` API Object as proposed in kubernetes/community#2514 and kubernetes/community#2034 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/enhancements#594 **Special notes for your reviewer**: Per the discussion in https://groups.google.com/d/msg/kubernetes-sig-storage-wg-csi/x5CchIP9qiI/D_TyOrn2CwAJ the API is being added to the staging directory of the `kubernetes/kubernetes` repo because the consumers will be attach/detach controller and possibly kubelet, but it will be installed as a CRD (because we want to move in the direction where the API server is Kubernetes agnostic, and all Kubernetes specific types are installed). **Release note**: ```release-note Introduce CSI Cluster Registration mechanism to ease CSI plugin discovery and allow CSI drivers to customize Kubernetes' interaction with them. ``` CC @jsafrane Kubernetes-commit: 85300f4f5dd7b0bd36d0538fb6c3255c06d5e6c2
Automatic merge from submit-queue (batch tested with PRs 64283, 67910, 67803, 68100). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. CSI Cluster Registry and Node Info CRDs **What this PR does / why we need it**: Introduces the new `CSIDriver` and `CSINodeInfo` API Object as proposed in kubernetes/community#2514 and kubernetes/community#2034 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/enhancements#594 **Special notes for your reviewer**: Per the discussion in https://groups.google.com/d/msg/kubernetes-sig-storage-wg-csi/x5CchIP9qiI/D_TyOrn2CwAJ the API is being added to the staging directory of the `kubernetes/kubernetes` repo because the consumers will be attach/detach controller and possibly kubelet, but it will be installed as a CRD (because we want to move in the direction where the API server is Kubernetes agnostic, and all Kubernetes specific types are installed). **Release note**: ```release-note Introduce CSI Cluster Registration mechanism to ease CSI plugin discovery and allow CSI drivers to customize Kubernetes' interaction with them. ``` CC @jsafrane Kubernetes-commit: 85300f4f5dd7b0bd36d0538fb6c3255c06d5e6c2
These objects and registry are designed for CSI drivers authors. No documentation changes needed on kubernetes/website. Changes will be added to kubernetes-csi |
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13? We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP |
@saad-ali, @jsafrane just checking in from @claurence's post to see if this should be included for tracking. thanks! |
/milestone v1.13 |
thanks for the updates @saad-ali |
@saad-ali - Is there any work needed left to make this feature beta for 1.13? As an FYI Code slush is 11/9 and Code freeze is 11/15 |
@jsafrane are there any PRs we should be tracking as we approach slush? kubernetes/kubernetes#69462 and any others? |
@jsafrane We are fast approaching Code freeze for 1.13 (11/6). I see kubernetes/kubernetes#69462 is still in active review. I also see atleast 3 more PRs referenced in kubernetes/kubernetes#69462? Are you confident of wrangling this by Wednesday this week giving us a couple of days to watch CI? If not please work with the release team to move this out to 1.14 sooner than later. thanks. |
@jsafrane @hoegaarden @vladimirvivien There hasn't been any progress on kubernetes/kubernetes#69462 in a long time. Should we punt this out to 1.14? |
PR to add a CRD installation mechanism: kubernetes/kubernetes#70780 I just discussed with @saad-ali and @davidz627 and we decided we're going to keep this feature in alpha for this release. We want to focus on CSI GA instead. |
These are the tasks we need to do to go to beta:
|
@kacole2 to move this out of 1.13 for Beta. Thanks |
@tfogo, @marpaia and @kbarnard10 to remove it from their updates respectively |
/milestone clear |
@claurence, yes, we plan to move it to GA. |
Thanks @jsafrane - any open PRs for this issue that we should track on the sheet? |
@jsafrane great - do y'all have a KEP for this issue? We want all issues to have a KEP by enhancements freeze. Also are there any PRs we should track? |
@jsafrane checking on a KEP for this issue - is there a PR open for a KEP? |
I discussed with @saad-ali and I don't think this needs to be a separate issue. This is defining a CRD that is used by two features:
The actual CRD installation mechanism is tracked by: #615 |
/milestone clear |
Feature Description
The text was updated successfully, but these errors were encountered: