Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some flags (breaking) #300

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Change some flags (breaking) #300

merged 3 commits into from
Nov 9, 2020

Conversation

thockin
Copy link
Member

@thockin thockin commented Nov 7, 2020 •
edited
Loading

  • Make the --root flag required, no default (breaking)
  • Don't allow --dest to start with a dot (breaking)
  • Rename the --dest flag to --link (old flag kept for compat)

See commit messages for more details.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2020
This was referenced Nov 8, 2020
Merged
Merged
Merged
stp-ip
stp-ip requested changes Nov 9, 2020
View reviewed changes
cmd/git-sync/main.go Outdated Show resolved Hide resolved
cmd/git-sync/main.go Outdated Show resolved Hide resolved
@thockin
Make the --root flag required, no default
af2ae5b 
BREAKING CHANGE

The default of $HOME has caused problems for people playing with
git-sync, so this change makes it a required argument.
@thockin
Don't allow --dest to start with a dot
0e80245 
BREAKING CHANGE

It's useful to reserve names that start with a dot.
@thockin
Fix SSH docs to use 2 dashes
a2fa689
@thockin
Copy link
Member Author

thockin commented Nov 9, 2020

re-push with those changes

stp-ip
stp-ip approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 719a93d into kubernetes:master Nov 9, 2020
@p-linnane p-linnane mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stp-ip stp-ip stp-ip approved these changes

Assignees

@stp-ip stp-ip

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thockin @k8s-ci-robot @stp-ip